Review main Merged

88098[TASK] Unify backend labels for file mounts

Lina Wolf CR +2 V +2 Normal +70 −70 updated 02/09/25, 20:58

Commit message

This change standardizes backend labels related
to file mounts, ensuring a more professional
and internationally consistent terminology across
affected modules.

The term "filemount" is less common in english than
in german, so it has been adjusted to "file mount" for
better readability and alignment with english conventions.

Additionally, all relevant comments in PHP code
have been updated to maintain consistency in
how the term is written.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 23

Show 3 more files

Review log 1113

  1. Lina Wolf uploaded patch set 1 02/08/25, 10:04

  2. core-ci voted on patch set 1 V +1 02/08/25, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73798

  3. Oliver Wand commented on patch set 1 CR +1 02/08/25, 10:12

    Even changing it within the @todo :D
  4. Garvin Hicking uploaded patch set 2 CR +1 V +1 02/08/25, 20:41

  5. Garvin Hicking commented on patch set 2 V +1 02/08/25, 20:42

    Found some more places.
  6. core-ci voted on patch set 2 V +1 02/08/25, 20:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73809

  7. Stefan Bürk commented on patch set 2 02/09/25, 20:14

    Feature-94374-CreateNewFilemountViaFoldersContextMenu.rst:6

    Should this change not also lead to a renaming of the filename ?

    Feature-99038-SubmoduleForFilemountsInBeUsermodule.rst:6

    File renaming kissing based on this change ?

    Feature-59570-AddDescriptionFieldForFilemounts.rst:7

    Filename renami g missing ?
  8. Christian Kuhn commented on patch set 2 02/09/25, 20:21

    Feature-94374-CreateNewFilemountViaFoldersContextMenu.rst:6 Reply

    i don't think this matter much in this case since there is no auto-magic between filename and title in .rst files: the should be roughly in sync, but there is no strict rule/magic applied to it.

    Feature-99038-SubmoduleForFilemountsInBeUsermodule.rst:6 Reply

    Done

    Feature-59570-AddDescriptionFieldForFilemounts.rst:7 Reply

    Done
  9. Christian Kuhn voted on patch set 2 CR +1 V +1 02/09/25, 20:29

  10. Stefan Bürk voted on patch set 2 CR +1 V +1 02/09/25, 20:38

  11. Christian Kuhn voted on patch set 2 CR +2 02/09/25, 20:58

  12. Christian Kuhn voted on patch set 2 V +2 02/09/25, 20:58

  13. Christian Kuhn merged patch set 3 02/09/25, 20:58