Review main Merged

88099[TASK] Rename DB mount label to "Page Tree Entry Point"

Lina Wolf CR +2 V +2 Normal +40 −35 updated 04/07/25, 10:30

Commit message

This field is used to grant access to pages and their subpages.
The original name was historically chosen but no longer accurately
reflects its function.

Additionally, a description has been added to the field's TCA
to remind administrators that page permissions must also be granted
for a Page Tree Entry Point to work.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Mathias Bolt Lesniak +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 18

Review log 4357

Show 2632 earlier messages
  1. Lina Wolf uploaded patch set 1 02/08/25, 10:36

  2. core-ci voted on patch set 1 V +1 02/08/25, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73799

  3. Oliver Wand voted on patch set 1 CR +1 02/08/25, 10:54

  4. Tymoteusz Motylewski commented on patch set 1 02/08/25, 11:58

    how other cms/dam systems are naming this? for me its more „folder mount” then „file mount” as you pick a folder not a file?
  5. Lina Wolf commented on patch set 1 02/08/25, 12:06

    Reply

    This change does not deal with file / folder mounts but with page / db mounts.
  6. Lina Wolf uploaded patch set 2 CR +1 V +1 02/17/25, 05:33

  7. core-ci voted on patch set 2 V +1 02/17/25, 05:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74233

  8. Riccardo De Contardi commented on patch set 2 V +1 02/22/25, 16:36

    verified on main
  9. Garvin Hicking voted on patch set 2 V +1 03/02/25, 18:04

  10. Georg Ringer commented on patch set 2 03/02/25, 21:40

    I don't know if this should be changed in 13? the wording "DB mount" is so well known.... don't wanna give a -1 either
  11. Lina Wolf commented on patch set 2 03/03/25, 05:22

    Reply

    Well I would argue, that experienced administrators will still find their way like the did now. For developers there is no difference as the database column was not renamed. There has been no outcry of any kind when Tables (listing) and Tables (modify) where combined into "Table permissions" even though two fields are now handled by one input element and the earlier naming has been there since ages.
  12. Simon Schaufelberger commented on patch set 2 CR +1 V +1 03/03/25, 10:45

    I really like this change! DB Mount is really not good wording
  13. Georg Ringer commented on patch set 2 CR -2 03/03/25, 13:39

    until discussed: changing the labels in main will lead to changes by translators at crowdin. those updated translated will then be automatically backported to 11, 10, 9, ... don't know if this is also desired by you?
  14. Lina Wolf commented on patch set 2 03/03/25, 14:08

    Reply

    What do you suggest, should we introduce a new label instead?
  15. Georg Ringer commented on patch set 2 03/03/25, 14:16

    Reply

    see discussion in coredev channel
  16. Lina Wolf marked it work in progress 03/03/25, 14:29

  17. Georg Ringer voted on patch set 2 CR 0 03/03/25, 14:29

  18. Lina Wolf commented on patch set 2 03/03/25, 14:31

    As discussed in #typo3-cms-coredev we will create a new label so that older versions are not affected
  19. Lina Wolf uploaded patch set 3 CR +1 V +1 03/03/25, 16:32

  20. core-ci voted on patch set 3 V +1 03/03/25, 16:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75030

  21. Georg Ringer commented on patch set 3 03/03/25, 17:17

    This change is ready for review.

    locallang.xlf:54

    shouldn't we use a different id here as well? also below
  22. Lina Wolf uploaded patch set 4 V +1 03/05/25, 13:00

  23. Lina Wolf uploaded patch set 5 03/05/25, 13:05

  24. Lina Wolf commented on patch set 5 03/05/25, 13:05

    locallang.xlf:54 Reply

    Done, the latter was not in use
  25. core-ci voted on patch set 5 V +1 03/05/25, 13:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75173

  26. Georg Ringer commented on patch set 5 03/05/25, 13:23

    locallang_core.xlf:302

    so we need a new translation here as well
  27. Lina Wolf uploaded patch set 6 V +1 03/05/25, 13:25

  28. core-ci voted on patch set 6 V -1 03/05/25, 13:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75177

  29. Lina Wolf uploaded patch set 7 V -1 03/05/25, 13:45

  30. Lina Wolf commented on patch set 7 03/05/25, 13:45

    locallang_core.xlf:302 Reply

    Done
  31. core-ci voted on patch set 7 V +1 03/05/25, 13:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75182

  32. Lina Wolf rebased onto patch set 8 V +1 03/21/25, 12:19

  1. core-ci voted on patch set 8 V +1 03/21/25, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75954

  2. Georg Ringer voted on patch set 8 CR +1 V +1 03/21/25, 19:49

  3. Riccardo De Contardi commented on patch set 8 V +1 03/21/25, 21:35

    tested on latest main
  4. Mathias Bolt Lesniak commented on patch set 8 03/22/25, 14:43

    Big kudos for the idea to change this label. "DB mount" has given me reflux for decades. However (and I'm sorry for coming late to the party) "Access Mount" is quite a mouthful. "Access" is redundant, so "Page Tree Mount" would carry the same meaning. Additionally, "Mount" (though common in computer lingo) isn't the most self-explanatory term. All of these examples would mean the same, but use easier words that can be understood also by people with more limited English: A. Page Tree Entry Point (my favorite) B. Page Tree Starting Point C. Page Tree Access Point
  5. Lina Wolf commented on patch set 8 03/22/25, 15:53

    Reply

    My idea was actually to leave the „mount“ part to cater to those already used to it and mention „access“ for those who are nnot fsmilar with mounts. what do you think
  6. Mathias Bolt Lesniak commented on patch set 8 03/22/25, 16:25

    Reply

    I still think "Access" should be removed. We can always string redundant terms together to increase the chance of being understood (we can add more words too). But that's still only the second-best solution. I believe best solution will always be to choose a brief and easy-to-understand term that doesn't need explanation in the first place, like with "Page Tree Entry Point".
  7. Lina Wolf updated the commit message in patch set 9 CR +1 V +1 04/02/25, 13:11

  8. Lina Wolf uploaded patch set 10 04/02/25, 13:12

  9. Lina Wolf commented on patch set 10 04/02/25, 13:15

    Reply

    Good Point! Changed the label to "Page Tree Entry Points" (as more then one is possible I chose plural)
  10. Lina Wolf updated the commit message in patch set 11 04/02/25, 13:15

  11. core-ci voted on patch set 9 V +1 04/02/25, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76884

  12. core-ci voted on patch set 10 V -1 04/02/25, 13:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76885

  13. core-ci voted on patch set 11 V -1 04/02/25, 13:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76886

  14. Andreas Kienast uploaded patch set 12 V -1 04/02/25, 13:27

  15. core-ci voted on patch set 12 V +1 04/02/25, 13:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76887

  16. Lina Wolf updated the commit message in patch set 13 V +1 04/02/25, 14:01

  17. core-ci voted on patch set 13 V +1 04/02/25, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76890

  18. Lina Wolf uploaded patch set 14 V +1 04/03/25, 10:08

  19. core-ci voted on patch set 14 V +1 04/03/25, 10:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76935

  20. Lina Wolf uploaded patch set 15 V +1 04/03/25, 10:15

  21. core-ci voted on patch set 15 V +1 04/03/25, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76936

  22. Mathias Bolt Lesniak voted on patch set 15 CR +1 04/03/25, 11:40

  23. Benni Mack voted on patch set 15 CR +1 V +1 04/03/25, 18:12

  24. Christian Kuhn voted on patch set 15 CR +2 V +2 04/07/25, 10:29

  25. Christian Kuhn merged patch set 16 04/07/25, 10:30