88101[TASK] Move be_users/be_groups workspace_perms to other tab
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Jasmina Ließmann +1
-
Verified V +2 Done
- Christian Kuhn +2
- Jasmina Ließmann +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1923
-
Lina Wolf uploaded patch set 1 02/08/25, 12:28
-
core-ci voted on patch set 1 V +1 02/08/25, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73802
-
Lina Wolf uploaded patch set 2
V +102/08/25, 12:35 -
core-ci voted on patch set 2 V +1 02/08/25, 12:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73803
-
Oli Bartsch commented on patch set 2 02/08/25, 21:10
Moving workspaces to the options tab and renaming the mounts tab is a good improvement. However, moving mfa_providers to the options tab while leaving dashboard widgets in the "Module permissions" does IMO not resolve the situation. I therefore suggest to keep mfa_providers there but rename the tab to "Component Permissions". This makes clear that this tab allows to configure permission for different kind of components: Modules, Dashboard Widgets and MFA providers. -
Lina Wolf commented on patch set 2 02/09/25, 06:24
Reply
I will break this up into two changes that can be discussed separately. -
Lina Wolf uploaded patch set 3
V +102/09/25, 06:27 -
Lina Wolf commented on patch set 3 02/09/25, 06:28
Reply
Done -
core-ci voted on patch set 3 V +1 02/09/25, 06:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73828
-
Christian Kuhn commented on patch set 3 02/10/25, 11:19
Reply
I kinda tend to agree to Oliver and would suggest a merge of the two approaches: * "workspace_perms" is a an option related to the workspace module. It feels to me as if the best fit would be tab "Module Permissions", not "Options" and of course not "Mounts and workspaces". * Renaming of "Mounts and Workspaces" to "Mounts" after "workspace_perms" has been moved out of it sounds good to me. * I'm also not *that* happy with "Options" tab that contains "tsconfig" only. I find myself constantly searching for this one and "Options" is somehow often the last one I click. I would thus rather suggest to rename "Options" to TSconfig, but I think *this* details should go to a separated patch in case we want to pick this idea up. So: workspace_perms to "Module Permissions" (I don't care about position much, top would be fine with me since it's such a small toggle only), then rename "Mounts and Workspaces" to "Mounts". Is that a good idea? -
Oli Bartsch commented on patch set 3 02/10/25, 11:54
Reply
Sounds good to me. -
Christian Kuhn commented on patch set 3 02/10/25, 13:03
Reply
Ok. Will push to see what happens. I'll also rename be_users tab "Permissions" to "Module Permissions" to have it in-sync with the same tab name in be_groups. -
Christian Kuhn uploaded patch set 4
V +102/10/25, 13:06 -
core-ci voted on patch set 4 V +1 02/10/25, 13:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73893
-
Jasmina Ließmann commented on patch set 4 02/10/25, 13:47
My two cents: I'm not entirely convinced. I don't like the idea of moving the `workspace_perms` field to the bottom. It gets lost there after all the larger tables in the "Module Permissions" tab. I feel that neither `mfa_providers` nor `workspace_perms` belong in a tab called "Module Permissions". Just as `allowed_languages` doesn't belong under "Record permissions" for me. For me, these are more global things, beyond modules or records. -
Lina Wolf commented on patch set 4 02/10/25, 13:50
Reply
I agree, they get lost under the large tables and they do not logically belong there. If we don't use the the options maybe something like global permissions? -
Jasmina Ließmann commented on patch set 4 02/10/25, 14:04
Reply
Then we would have three different tabs that have "Permissions" in their names :/ The `mfa` field is already located for be_users within the "General" tab. Perhaps we could move `mfa_providers` for be_groups to the "General" tab as well. Likewise the `workspace_perms` fields for both tables. The tables 'be_users' and 'be_groups' could generally do with a few palettes. If OK, I would take a look at that for v14. -
Lina Wolf commented on patch set 4 02/10/25, 14:12
Reply
That might be a good idea, If you have workspaces installed, the workspace permissions are quite important and if you don't you don't see them anyway About the mfa_providers, it is probably a good idea to make it more obvous -
Jasmina Ließmann commented on patch set 4 02/10/25, 18:45
Reply
FYI: To avoid hijacking this patch, I created a new one to add palettes to backend user and backend user group records: https://review.typo3.org/c/Packages/TYPO3.CMS/+/88146 The patch introduces some new language keys, therefore it is v14 only. -
Jasmina Ließmann commented on patch set 4 CR +1 V +1 02/13/25, 09:38
Reply
Will close my request as integrating palettes is part of https://review.typo3.org/c/Packages/TYPO3.CMS/+/88146. Position of 'workspace_perms' for the time being is ok for me. -
Lina Wolf commented on patch set 4 02/17/25, 05:26
Reply
The workspace_perms are in the tab "Module Permissions now" -
Christian Kuhn commented on patch set 4 CR +2 V +2 03/03/25, 13:45
talked with jasmina again. we'll pick this now. -
Christian Kuhn merged patch set 5 03/03/25, 14:20