Review main Abandoned

88105[FEATURE] Combine Plugin and FlexForm Registration

Lina Wolf CR -1 V -1 Hard +227 −49 updated 06/25/25, 14:08

Commit message

Many plugins rely on FlexForms for configuration. Previously, adding
a FlexForm to a plugin required multiple steps:
1. Creating the plugin's TCA,
2. Making the `pi_flexform` field visible,
3. Registering a file path containing the FlexForm XML.

With this change, all these steps can be combined into a single API call.
A FlexForm path has been added as a second parameter to
`ExtensionManagementUtility::addPlugin()` and as a seventh parameter to
`ExtensionUtility::registerPlugin()`.

`ExtensionManagementUtility::addPiFlexFormValue()` was heavily dependent
on `list_type` handling, which was removed in
https://review.typo3.org/c/Packages/TYPO3.CMS/+/86879. As a result,
it has been deprecated and replaced.

Review

  • Code review CR -1
    • Stefan Bürk -1
  • Verified V -1
    • Oli Bartsch -1
    • core-ci +1 CI

Issues 1

Files 9

Review log 78

  1. Lina Wolf uploaded patch set 1 02/08/25, 19:04

  2. core-ci voted on patch set 1 V +1 02/08/25, 19:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73808

  3. Stefan Bürk commented on patch set 1 CR -1 02/08/25, 20:57

    Reviewing ...
  4. Oli Bartsch commented on patch set 1 V -1 02/08/25, 21:31

    Hi Lina, thanks for your patch! I appreciate your initiative to improve FlexForm. We are already working on a broader restructuring to simplify its logic by removing `ds_pointerField` and making `ds` directly reference a data structure instead of containing a sub-array that requires additional processing. Your patch, as well as Simon’s (https://review.typo3.org/c/Packages/TYPO3.CMS/+/87504), addresses part of this larger refactoring I’ve been working on (https://review.typo3.org/c/Packages/TYPO3.CMS/+/87161). To keep everything aligned and avoid redundant work, I’d love to coordinate our efforts. Let’s discuss how we can integrate this into the bigger picture and move forward together!
  5. Oli Bartsch commented on patch set 1 02/08/25, 21:33

  6. Stefan Bürk commented on patch set 1 02/08/25, 21:35

    Reply

    obsolete, see comment from oliver.
  7. Stefan Bürk commented on patch set 1 02/09/25, 19:22

    Unresolved

    One note - I'm not sure if we should deprecated `ExtensionManagementUtility::addPiFlexFormValue()`. (Having internet issues right now, will investigate/comment more when internet issues has been solved hopefully tomorrow).
  8. Lina Wolf abandoned the change 06/25/25, 14:08