Review main Merged

88108[BUGFIX] Workaround initialization race condition in tree-module-state

Benjamin Franzke CR +2 V +2 Easy +5 −1 updated 02/10/25, 08:39

Commit message

The tree module state event handler for module state
updates is registered in a web components connected
callback. That means there is a timeframe between
event handler registration and tree initialiation,
where module updates can not yet be consumed.

These module updates are skipped for now, but should
be collected in a stack later on to be consumed lazy
(also for events that possibly arrive before the
connectedCallback of the tree-module-state mixin).

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 45

  1. Benjamin Franzke uploaded patch set 1 02/09/25, 02:26

  2. core-ci voted on patch set 1 V +1 02/09/25, 02:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73818

  3. Benni Mack voted on patch set 1 CR +1 V +1 02/09/25, 12:20

  4. Andreas Kienast voted on patch set 1 CR +2 V +2 02/10/25, 08:28

  5. Andreas Kienast merged patch set 2 02/10/25, 08:39