Review main Merged

88110[BUGFIX] Use backed enums in Workspace comparison

Benni Mack CR +2 V +2 Easy +3 −25 updated 02/10/25, 10:57

Commit message

When introducing VersionState Enum
for t3ver_state, some issues were introduced
which PHPStan actually found to be (still) valid.

The main issue happened when deleting a record
in a workspace, which might have impact on translations
of this record in a workspace, which might not be shown
in the Workspaces module anymore.

They are removed along with a few minor
other changes related to PHPStan.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 912

  1. Benni Mack uploaded patch set 1 02/09/25, 12:25

  2. core-ci voted on patch set 1 V +1 02/09/25, 12:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73833

  3. Benni Mack updated the commit message in patch set 2 V +1 02/10/25, 08:08

  4. Garvin Hicking commented on patch set 2 02/10/25, 08:13

    Could you mention here or in the ticket what this meant for functionality? this "always returns true" kind of sounds high-impact to versioning?
  5. core-ci voted on patch set 2 V +1 02/10/25, 08:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73881

  6. Benni Mack updated the commit message in patch set 3 V +1 02/10/25, 09:11

  7. Benni Mack commented on patch set 3 02/10/25, 09:11

    Reply

    It only affected the "view" in The backend.
  8. core-ci voted on patch set 3 V +1 02/10/25, 09:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73883

  9. Christian Kuhn voted on patch set 3 CR +1 V +1 02/10/25, 09:36

  10. Georg Ringer voted on patch set 3 CR +1 V +1 02/10/25, 10:18

  11. Christian Kuhn voted on patch set 3 CR +2 V +2 02/10/25, 10:38

  12. Christian Kuhn merged patch set 4 02/10/25, 10:57