Review main Merged

88114[TASK] Streamline ext:workspaces DataHandlerHook and logging

Christian Kuhn CR +2 V +2 Hard +98 −196 updated 02/09/25, 19:19

Commit message

* Use DI for DB connection instead of using GU::makeInstance()
  all over the place
* Inline method emitUpdateTopbarSignal() to consumers
* Streamline some comments
* Avoid obsolete casts
* Use early return in version_swap on SQL error
* Rename "versionized" to "versioned" in a couple of variables
* Overall more dense code

Additionally, version_swap() removes two log cases:
* `if ($propArr['t3ver_oid'])` is never true since `t3ver_oid`
  is not part of the DH->getRecordPropertiesFromRow() array
  result set
* It does not make sense to add a log entry and history for
  $curVersion / $swapWith (the live record being taken offline)
  since that record is deleted / discarded afterwards which
  triggers an own log row about its deletion. This detail is a
  sane conclusion of #92206.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Nedbal +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Nedbal +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 913

  1. Christian Kuhn uploaded patch set 1 02/09/25, 16:25

  2. core-ci voted on patch set 1 V +1 02/09/25, 16:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73840

  3. Christian Kuhn updated the commit message in patch set 2 V +1 02/09/25, 16:44

  4. Christian Kuhn updated the commit message in patch set 3 02/09/25, 16:49

  5. core-ci voted on patch set 2 V +1 02/09/25, 16:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73841

  6. Christian Kuhn updated the commit message in patch set 4 02/09/25, 16:50

  7. core-ci voted on patch set 3 V +1 02/09/25, 16:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73842

  8. core-ci voted on patch set 4 V +1 02/09/25, 16:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73843

  9. Andreas Nedbal voted on patch set 4 CR +1 V +1 02/09/25, 18:26

  10. Benni Mack commented on patch set 4 CR +1 V +1 02/09/25, 18:57

    nice one!
  11. Stefan Bürk commented on patch set 4 CR +1 V +1 02/09/25, 19:10

    +1
  12. Christian Kuhn voted on patch set 4 CR +2 V +2 02/09/25, 19:19

  13. Christian Kuhn merged patch set 5 02/09/25, 19:19