88115[TASK] Streamline DataHandler->process_datamap() #2
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Andreas Nedbal +1
- Stefan Bürk +1
- Andreas Wolf +1
-
Verified V +2 Done
- Christian Kuhn +2
- Andreas Nedbal +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1520
-
Christian Kuhn uploaded patch set 1 02/09/25, 17:18
-
core-ci voted on patch set 1 V -1 02/09/25, 17:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73844
-
core-ci voted on patch set 1 V +1 02/09/25, 17:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73844
-
Christian Kuhn updated the commit message in patch set 2
V +102/09/25, 17:31 -
core-ci voted on patch set 2 V +1 02/09/25, 17:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73845
-
Christian Kuhn updated the commit message in patch set 3
V +102/09/25, 17:47 -
core-ci voted on patch set 3 V +1 02/09/25, 18:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73850
-
Stefan Bürk voted on patch set 3 CR +1 V +1 02/09/25, 19:08
-
Christian Kuhn voted on patch set 3 CR -1 02/09/25, 20:28
-
Christian Kuhn commented on patch set 3 02/09/25, 21:00
got feedback from andy wolf the handing of $old_pid_value may be broken now. -
Andreas Wolf commented on patch set 3 02/09/25, 21:11
DataHandler.php:966I think the third parameter should be "$fieldArray['pid'] ?? 0", since it used to be "$old_pid_value ?: ($fieldArray['pid'] ?? 0)" and $old_pid_value was '' before. -
Christian Kuhn uploaded patch set 4
CR +1V +102/10/25, 10:35 -
Christian Kuhn commented on patch set 4 02/10/25, 10:37
DataHandler.php:966Replyphpstan: "Offset 'pid' on array{} on left side of ?? does not exist." $fieldArray is initialized to an empty array in else "update" branch. We should input int 0. -
core-ci voted on patch set 4 V +1 02/10/25, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73884
-
Stefan Bürk voted on patch set 4 CR +1 02/10/25, 12:26
-
Andreas Nedbal voted on patch set 4 CR +1 V +1 02/10/25, 13:12
-
Stefan Bürk voted on patch set 4 V +1 02/10/25, 13:29
-
Andreas Wolf voted on patch set 4 CR +1 02/10/25, 14:29
-
Christian Kuhn voted on patch set 4 CR +2 V +2 02/10/25, 14:55
-
Christian Kuhn merged patch set 5 02/10/25, 14:55