Review 13.4 Merged

88125[BUGFIX] Fix site set label loading on windows

Christian Kuhn CR +2 V +2 Easy +37 −13 updated 02/09/25, 19:33

Commit message

The site set labels are loaded via an absolute
file path. That means a string like
LLL:C:/web/typo3/sysext/seo/Configuration/Sets/Sitemap/labels.xlf:label
is passed to the language API, where three colons are included because
of drives on windows (`C:/`).

Adapt the LLL string parser to be able to parse this kind of label
and pick the language from the part after the last colon, instead of
omitting the entire string after the second colon.

Also remove a previous workaround which was added to circumvent
the same parsing issue for the colon of the `EXT:`-prefix, which
is no longer needed with this fix.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 34

  1. Christian Kuhn uploaded patch set 1 02/09/25, 19:25

  2. core-ci voted on patch set 1 V +1 02/09/25, 19:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73860

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 02/09/25, 19:33

  4. Christian Kuhn merged patch set 2 02/09/25, 19:33