Review 13.4 Merged

88131[BUGFIX] Use backed enums in Workspace comparison

Christian Kuhn CR +2 V +2 Easy +3 −25 updated 02/10/25, 10:57

Commit message

When introducing VersionState Enum
for t3ver_state, some issues were introduced
which PHPStan actually found to be (still) valid.

The main issue happened when deleting a record
in a workspace, which might have impact on translations
of this record in a workspace, which might not be shown
in the Workspaces module anymore.

They are removed along with a few minor
other changes related to PHPStan.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 2

Files 4

Review log 34

  1. Christian Kuhn uploaded patch set 1 02/10/25, 10:38

  2. core-ci voted on patch set 1 V +1 02/10/25, 10:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73885

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 02/10/25, 10:57

  4. Christian Kuhn merged patch set 2 02/10/25, 10:57