Review 13.4 Merged

88136[TASK] Streamline DataHandler->process_datamap() #2

Christian Kuhn CR +2 V +2 Normal +88 −117 updated 02/10/25, 14:55

Commit message

This is a classic "divide & conquer" change in process_datamap().
The main foreach() in process_datamap() is constructed like this:

if (this is a new record) {
  $status = 'new';
  ...
} else {
  $status = 'update';
  ...
}
if ($status = "new") {
  ...
) else {
  ...
}

The patch inlines "all work for new" to the "new" branch, and
"all work for update" to the "update" branch.

This allows looking and optimizing single code branches without
much code duplication.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 34

  1. Christian Kuhn uploaded patch set 1 02/10/25, 14:43

  2. core-ci voted on patch set 1 V +1 02/10/25, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73896

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 02/10/25, 14:55

  4. Christian Kuhn merged patch set 2 02/10/25, 14:55