Review main Merged

88138[TASK] Use ForwardResponse instead of redirect in indexed search

Garvin Hicking CR +2 V +2 Easy +3 −2 updated 02/10/25, 20:55

Commit message

When TypoScript config is missing for EXT:indexed_search,
the extbase action handling uses a redirect to
`noTypoScriptAction`, which changes the URI of a request
to point to that action.

When fixing the TypoScript configuration, a page reload
will thus still show the same error, resulting in a bad
developer experience.

By using a ForwardResponse() instead, the same output
can be displayed without a change of the URI.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1113

  1. Garvin Hicking uploaded patch set 1 02/10/25, 15:26

  2. core-ci voted on patch set 1 V +1 02/10/25, 15:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73900

  3. Benni Mack voted on patch set 1 CR +1 02/10/25, 20:02

  4. Benni Mack voted on patch set 1 V +1 02/10/25, 20:18

  5. Christian Kuhn voted on patch set 1 CR +1 V +1 02/10/25, 20:20

  6. Garvin Hicking voted on patch set 1 CR +2 V +2 02/10/25, 20:24

  7. Benni Mack updated the commit message in patch set 2 CR +1 V +1 02/10/25, 20:27

  8. Garvin Hicking voted on patch set 2 CR +1 V +1 02/10/25, 20:28

  9. Benni Mack voted on patch set 2 CR +1 V +1 02/10/25, 20:35

  10. Oli Bartsch voted on patch set 2 CR +1 V +1 02/10/25, 20:35

  11. core-ci voted on patch set 2 V +1 02/10/25, 20:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73935

  12. Georg Ringer voted on patch set 2 CR +2 V +2 02/10/25, 20:55

  13. Georg Ringer merged patch set 3 02/10/25, 20:55