Review main Abandoned

88141[BUGFIX] Fix bug when an image is a processed image

Florian Rival CR 0 V 0 Easy +6 −6 updated 02/11/25, 11:41

Commit message

Check if the file given image is an instance of AbstractFile (i.e. File or ProcessedFile)

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1011

  1. Florian Rival uploaded patch set 1 02/10/25, 15:57

  2. core-ci voted on patch set 1 V -1 02/10/25, 16:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73903

  3. Garvin Hicking commented on patch set 1 02/10/25, 16:29

    Could you tell why/how you pass a processed image to f:image? I haven't seen this yet, because f:image actually wants a sys_file object and not a processed file due to follow-up operations...? I think this would allow a spiral into follow-up issues.
  4. Mathias Brodala commented on patch set 1 CR -1 02/11/25, 07:43

    Reply

    The related Forge ticket shows what he does: <f:image src="/fileadmin/_processed_/6/2/csm_session-my-image_0fc684693d.jpg" alt="" maxWidth="800"/> Which is simply wrong from my POV. And it's not necessary; one can simply render the original image again with a different scaling configuration.
  5. Garvin Hicking commented on patch set 1 02/11/25, 08:40

    Reply Unresolved

    Yes, I saw that - hence the question for "why". I also think this creates more trouble than it would solve and if maybe I'm not seeing a valid use-case for this.
  6. Florian Rival commented on patch set 1 02/11/25, 09:30

    The use case is this one, I have an thumbnail field in page properties which is indexed in solr like this : index_thumbnail_stringS = FILES index_thumbnail_stringS { references { table = pages uid.data = field:uid fieldName = tx_arcprojet_thumbnail } maxItems = 1 renderObj = TEXT renderObj { typolink { parameter.stdWrap { cObject = IMG_RESOURCE cObject { file.import.data = file:current:uid file.treatIdAsReference = 1 file.height = 400c file.width = 400 } } returnLast = url forceAbsoluteUrl = 0 } stdWrap.wrap = | } } Due to the rendering with the object IMG_RESOURCE, the file is processed and the URL that I get is the processed URL. This use case worked with older TYPO3 version, but perhaps it is a bad practice to store processed images and the rendering must be only done at runtime.
  7. Garvin Hicking commented on patch set 1 02/11/25, 09:46

    Reply

    Hm. I wonder if better you should/could transport not the URL but the file identifier back to typoscript and fluid, then you could do any kind if pre/reprocessing basedd on that UID. Or pass the identifier additionally to the TS rendered image for this additional reprocessing...?
  8. Mathias Brodala commented on patch set 1 02/11/25, 10:05

    Reply

    In any case this should be discussed elsewhere, either TYPO3 Slack or in the context of a TYPO3 Solr Github issue. ;-) Can you abandon this change and close the Forge ticket with a comment?
  9. Florian Rival commented on patch set 1 02/11/25, 11:34

    Don't find where I can change the status in Forge ticket. May be I can't.

    Reply Unresolved

    Don't find where I can change the status in Forge ticket. May be I can't.
  10. Mathias Brodala commented on patch set 1 02/11/25, 11:36

    Reply Unresolved

    No problem, just closed the Forge ticket for you. But I cannot abandon your change here, so you'll need to do that yourself.
  11. Florian Rival abandoned the change 02/11/25, 11:41

    Avoid using pre/processed images with ViewHelper <f:image>