88142[TASK] Use Schema API in EXT:lowlevel
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/core/Classes/DataHandling/PageDoktypeRegistry.php+18 −0
- typo3/sysext/lowlevel/Classes/Command/CleanFlexFormsCommand.php2+20 −21
- typo3/sysext/lowlevel/Classes/Command/DeletedRecordsCommand.php+10 −8
- typo3/sysext/lowlevel/Classes/Command/MissingRelationsCommand.php+10 −6
- typo3/sysext/lowlevel/Classes/ConfigurationModuleProvider/PageDoktypeProvider.php+9 −9
- typo3/sysext/lowlevel/Classes/Controller/DatabaseIntegrityController.php+368 −308
- typo3/sysext/lowlevel/Classes/Integrity/DatabaseIntegrityCheck.php+92 −66
- typo3/sysext/lowlevel/Tests/Functional/Controller/DatabaseIntegrityControllerTest.php+27 −3
Review log 2135
Show 510 earlier messages
-
Benni Mack uploaded patch set 1 02/10/25, 16:17
-
core-ci voted on patch set 1 V -1 02/10/25, 16:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73905
-
Benni Mack uploaded patch set 2
V -102/10/25, 16:37 -
core-ci voted on patch set 2 V -1 02/10/25, 16:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73907
-
Benni Mack uploaded patch set 3
V -102/10/25, 20:00 -
core-ci voted on patch set 3 V -1 02/10/25, 20:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73930
-
Benni Mack uploaded patch set 4
V -102/11/25, 13:50 -
core-ci voted on patch set 4 V -1 02/11/25, 14:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73981
-
Benni Mack uploaded patch set 5
V -102/11/25, 14:12 -
core-ci voted on patch set 5 V -1 02/11/25, 14:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73984
-
Benni Mack updated the commit message in patch set 6
V -102/11/25, 15:32 -
core-ci voted on patch set 6 V -1 02/11/25, 15:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73998
-
Benni Mack uploaded patch set 7
V -102/11/25, 20:05 -
core-ci voted on patch set 7 V -1 02/11/25, 20:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74007
-
Benni Mack uploaded patch set 8
V -102/11/25, 21:20 -
Benni Mack uploaded patch set 9 02/11/25, 21:23
-
core-ci voted on patch set 8 V -1 02/11/25, 21:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74008
-
core-ci voted on patch set 9 V -1 02/11/25, 21:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74009
-
Benni Mack uploaded patch set 10
V -103/06/25, 21:19 -
core-ci voted on patch set 10 V -1 03/06/25, 21:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75248
-
Benni Mack uploaded patch set 11
V -103/10/25, 15:20 -
core-ci voted on patch set 11 V -1 03/10/25, 15:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75426
-
Benni Mack uploaded patch set 12
V -103/10/25, 15:50 -
core-ci voted on patch set 12 V +1 03/10/25, 15:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75427
-
Benni Mack updated the commit message in patch set 13
V +103/10/25, 16:20 -
core-ci voted on patch set 13 V +1 03/10/25, 16:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75429
-
Georg Ringer voted on patch set 13 CR +1 V +1 03/11/25, 19:20
-
Garvin Hicking commented on patch set 13 03/14/25, 22:57
-
Garvin Hicking commented on patch set 13 CR -1 03/14/25, 22:58
reviewing, addressing generator iteration -
Garvin Hicking uploaded patch set 14
CR +1V +103/14/25, 23:37Adjust some edges -
Garvin Hicking commented on patch set 14 CR +1 V +1 03/14/25, 23:41
I've adjusted two things: - The generator cannot be re-iterated in cleanup flexforms, so I made an intermediate re-traversable array. Please check if that works out for you. - The TCA for tx_styleguide_elements_basic does not provide a primaryField and yielded type errors for accessing a null object. I've added checks for a primaryField in three cases. I've played around with all commands and the DB integrity and couldn't find further issues. (Sidenote, as you told me, the bug from https://review.typo3.org/c/Packages/TYPO3.CMS/+/86193 will be addressed in a follow-up, and still stands with the current implementation)CleanFlexFormsCommand.php:99ReplyDone -
core-ci voted on patch set 14 V +1 03/14/25, 23:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75622
-
Christian Kuhn voted on patch set 14 CR +1 V +1 03/18/25, 17:55
-
Benni Mack commented on patch set 14 CR +2 V +2 03/19/25, 11:51
thank you! -
Benni Mack merged patch set 15 03/19/25, 11:51
CleanFlexFormsCommand.php:99