Review main Merged

88142[TASK] Use Schema API in EXT:lowlevel

Benni Mack CR +2 V +2 Hard +554 −421 updated 03/19/25, 11:51

Commit message

Ensure to use Schema API over $GLOBALS[TCA]
in all of EXT:lowlevel.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 2135

Show 510 earlier messages
  1. Benni Mack uploaded patch set 1 02/10/25, 16:17

  2. core-ci voted on patch set 1 V -1 02/10/25, 16:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73905

  3. Benni Mack uploaded patch set 2 V -1 02/10/25, 16:37

  4. core-ci voted on patch set 2 V -1 02/10/25, 16:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73907

  5. Benni Mack uploaded patch set 3 V -1 02/10/25, 20:00

  6. core-ci voted on patch set 3 V -1 02/10/25, 20:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73930

  7. Benni Mack uploaded patch set 4 V -1 02/11/25, 13:50

  8. core-ci voted on patch set 4 V -1 02/11/25, 14:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73981

  9. Benni Mack uploaded patch set 5 V -1 02/11/25, 14:12

  10. core-ci voted on patch set 5 V -1 02/11/25, 14:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73984

  1. Benni Mack updated the commit message in patch set 6 V -1 02/11/25, 15:32

  2. core-ci voted on patch set 6 V -1 02/11/25, 15:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73998

  3. Benni Mack uploaded patch set 7 V -1 02/11/25, 20:05

  4. core-ci voted on patch set 7 V -1 02/11/25, 20:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74007

  5. Benni Mack uploaded patch set 8 V -1 02/11/25, 21:20

  6. Benni Mack uploaded patch set 9 02/11/25, 21:23

  7. core-ci voted on patch set 8 V -1 02/11/25, 21:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74008

  8. core-ci voted on patch set 9 V -1 02/11/25, 21:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74009

  9. Benni Mack uploaded patch set 10 V -1 03/06/25, 21:19

  10. core-ci voted on patch set 10 V -1 03/06/25, 21:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75248

  11. Benni Mack uploaded patch set 11 V -1 03/10/25, 15:20

  12. core-ci voted on patch set 11 V -1 03/10/25, 15:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75426

  13. Benni Mack uploaded patch set 12 V -1 03/10/25, 15:50

  14. core-ci voted on patch set 12 V +1 03/10/25, 15:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75427

  15. Benni Mack updated the commit message in patch set 13 V +1 03/10/25, 16:20

  16. core-ci voted on patch set 13 V +1 03/10/25, 16:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75429

  17. Georg Ringer voted on patch set 13 CR +1 V +1 03/11/25, 19:20

  18. Garvin Hicking commented on patch set 13 03/14/25, 22:57

    CleanFlexFormsCommand.php:99

    Error: ``` In CleanFlexFormsCommand.php line 99: Cannot traverse an already closed generator ```
  19. Garvin Hicking commented on patch set 13 CR -1 03/14/25, 22:58

    reviewing, addressing generator iteration
  20. Garvin Hicking uploaded patch set 14 CR +1 V +1 03/14/25, 23:37

    Adjust some edges
  21. Garvin Hicking commented on patch set 14 CR +1 V +1 03/14/25, 23:41

    I've adjusted two things: - The generator cannot be re-iterated in cleanup flexforms, so I made an intermediate re-traversable array. Please check if that works out for you. - The TCA for tx_styleguide_elements_basic does not provide a primaryField and yielded type errors for accessing a null object. I've added checks for a primaryField in three cases. I've played around with all commands and the DB integrity and couldn't find further issues. (Sidenote, as you told me, the bug from https://review.typo3.org/c/Packages/TYPO3.CMS/+/86193 will be addressed in a follow-up, and still stands with the current implementation)

    CleanFlexFormsCommand.php:99 Reply

    Done
  22. core-ci voted on patch set 14 V +1 03/14/25, 23:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75622

  23. Christian Kuhn voted on patch set 14 CR +1 V +1 03/18/25, 17:55

  24. Benni Mack commented on patch set 14 CR +2 V +2 03/19/25, 11:51

    thank you!
  25. Benni Mack merged patch set 15 03/19/25, 11:51