88159[TASK] Reduce DH->getRecordProperties() usages
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 3
Review log 1626
Show 1 earlier messages
-
Christian Kuhn uploaded patch set 1 02/10/25, 21:54
-
core-ci voted on patch set 1 V +1 02/10/25, 22:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73943
-
Christian Kuhn uploaded patch set 2
V +102/10/25, 22:19 -
core-ci voted on patch set 2 V +1 02/10/25, 22:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73944
-
Christian Kuhn uploaded patch set 3
V +102/11/25, 08:52 -
core-ci voted on patch set 3 V +1 02/11/25, 09:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73972
-
Christian Kuhn uploaded patch set 4
V +102/11/25, 12:04 -
core-ci voted on patch set 4 V +1 02/11/25, 12:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73975
-
Christian Kuhn uploaded patch set 5
V +102/11/25, 12:58 -
Christian Kuhn uploaded patch set 6 02/11/25, 13:01
-
core-ci voted on patch set 5 V +1 02/11/25, 13:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73977
-
core-ci voted on patch set 6 V +1 02/11/25, 13:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73978
-
Christian Kuhn uploaded patch set 7
V +102/11/25, 13:36 -
core-ci voted on patch set 7 V +1 02/11/25, 13:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73980
-
Christian Kuhn uploaded patch set 8
V +102/11/25, 13:58 -
core-ci voted on patch set 8 V +1 02/11/25, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73982
-
Christian Kuhn uploaded patch set 9
V +102/11/25, 14:42 -
core-ci voted on patch set 9 V +1 02/11/25, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73992
-
Christian Kuhn updated the commit message in patch set 10
V +102/11/25, 14:59 -
core-ci voted on patch set 10 V +1 02/11/25, 15:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73994
-
Stefan Bürk commented on patch set 10 02/11/25, 15:46
DataHandler.php:1297`$currentRecord` may not be an array here - do we need a fallback ?DataHandler.php:1300`$currentRecord` may not be an array here - do we need a fallback ?DataHandler.php:5254Use `?? []` fallback here ? -
Christian Kuhn commented on patch set 10 02/11/25, 16:35
DataHandler.php:1295Replythis is "if ($table === 'be_users' && ($field === 'admin' || $field === 'password' && $status === 'update'): that's an update case: we could potentially sanitize better, but that's not scope of the patch and "previous" calls have already checked for record existance.DataHandler.php:1297Replysame as above.DataHandler.php:1300Replysame as above.DataHandler.php:5254Replyno benefit. -
Stefan Bürk voted on patch set 10 CR +1 V +1 02/11/25, 16:37
-
Benni Mack voted on patch set 10 CR +1 V +1 02/11/25, 16:44
-
Christian Kuhn voted on patch set 10 CR +2 V +2 02/11/25, 17:08
-
Christian Kuhn merged patch set 11 02/11/25, 17:08
DataHandler.php:1295