Review 12.4 Merged

88161[BUGFIX] Sanitize superfluous page-id from additional route arguments

Benni Mack CR +2 V +2 Normal +85 −0 updated 02/10/25, 22:51

Commit message

This change sanitizes a superfluous page-id from additional arguments
when creating URIs with PageRouter::generateUri() directly. When using
TypoScript 'typolink', PageLinkBuilder::calculateQueryParameters()
would have sanitized the superfluous page-id already.

* before: https://example.org/the-page-slug/?id=13
* after: https://example.org/the-page-slug

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 46

  1. Benni Mack commented on patch set 1 02/10/25, 22:28

    Cherry Picked from branch 13.4.
  2. core-ci voted on patch set 1 V -1 02/10/25, 22:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73946

  3. Benni Mack uploaded patch set 2 V -1 02/10/25, 22:43

  4. core-ci voted on patch set 2 V +1 02/10/25, 22:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73949

  5. Benni Mack voted on patch set 2 CR +2 V +2 02/10/25, 22:51

  6. Benni Mack merged patch set 3 02/10/25, 22:51