Review main Merged

88169[TASK] Hand StageChangeMessage around in ext:workspaces

Christian Kuhn CR +2 V +2 Normal +28 −40 updated 02/11/25, 14:40

Commit message

The "stage changed message" data object has been established
with #97700. It is easily possible to hand it around instead
of dealing with properties in StageChangeNotificationHandler.

Also, StageChangeNotification does not need to be public
anymore and we use named arguments for the final readonly
StageChangeMessage according to our rules.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 89

  1. Christian Kuhn uploaded patch set 1 02/11/25, 14:14

  2. Christian Kuhn updated the commit message in patch set 2 02/11/25, 14:16

  3. Christian Kuhn updated the commit message in patch set 3 02/11/25, 14:17

  4. Christian Kuhn rebased onto patch set 4 02/11/25, 14:18

  5. core-ci voted on patch set 4 V +1 02/11/25, 14:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73988

  6. Anja Leichsenring voted on patch set 4 CR +1 V +1 02/11/25, 14:28

  7. Stefan Bürk voted on patch set 4 CR +1 V +1 02/11/25, 14:33

  8. Christian Kuhn voted on patch set 4 CR +2 V +2 02/11/25, 14:40

  9. Christian Kuhn merged patch set 5 02/11/25, 14:40