Review 13.4 Merged

88171[TASK] Reduce DH->getRecordProperties() usages

Christian Kuhn CR +2 V +2 Hard +121 −175 updated 02/11/25, 17:08

Commit message

With getRecordPropertiesFromRow() being gone since #106147, the
next upper - mostly logging related - method to look at is
getRecordProperties().

The patch follows the same decisions taken with #106147. It gets
rid of half of getRecordProperties() usages and streamlines the
code within callers.

DataHandler methods moveRecord() and moveRecord_raw() are left
out: Those treat getRecordProperties() as API for hooks and need
special treatment with a dedicated patch.

The patch improves DataHandler performance slightly by skipping
two or three DB calls from getRecordProperties() and introducing
a couple of single BU::getRecord() calls instead. Most of the new
calls can be refactored away with further patches when DataHandler
hands the record in question around more often, which is one of
the major targets of all these preparation changes.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 2

Files 3

Review log 34

  1. Christian Kuhn uploaded patch set 1 02/11/25, 16:55

  2. core-ci voted on patch set 1 V +1 02/11/25, 17:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74002

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 02/11/25, 17:08

  4. Christian Kuhn merged patch set 2 02/11/25, 17:08