88173[BUGFIX] Prevent recycler failure when allowDelete=0 is set
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Andreas Kienast +1
-
Verified V +2 Done
- Garvin Hicking +2
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1520
-
Ursula Klinger uploaded patch set 1 02/11/25, 18:28
-
core-ci voted on patch set 1 V -1 02/11/25, 18:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74004
-
Ursula Klinger uploaded patch set 2
V -102/11/25, 18:45 -
core-ci voted on patch set 2 V +1 02/11/25, 18:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74005
-
Garvin Hicking updated the commit message in patch set 3
V +102/12/25, 07:08 -
Garvin Hicking commented on patch set 3 V +1 02/12/25, 07:08
This patch works for me -
core-ci voted on patch set 3 V +1 02/12/25, 07:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74031
-
Andreas Kienast commented on patch set 3 02/12/25, 07:14
I'd prefer to pass the actual configuration to the Recycler module and check the configuration instead the existence of arbitrary DOM elements. The latter may mask additional, undiscovered bugs. -
Andreas Kienast voted on patch set 3 CR -1 02/12/25, 07:15
-
Garvin Hicking uploaded patch set 4
CR -1V +102/12/25, 08:18 -
Garvin Hicking commented on patch set 4 02/12/25, 08:19
Thanks Ursula for this patch. I think I got to the root of the problem; the DOM element setup was already "good" so a chunk of the JS did simply not apply. Could you check out if my reworked patch also works for you? I've updated the patch's description for details. -
core-ci voted on patch set 4 V +1 02/12/25, 08:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74035
-
Garvin Hicking voted on patch set 4 CR +1 V +1 02/12/25, 08:58
-
Andreas Kienast uploaded patch set 5
CR +1V +102/14/25, 07:53 -
Andreas Kienast commented on patch set 5 CR +1 V +1 02/14/25, 07:53
Reply
Done -
core-ci voted on patch set 5 V +1 02/14/25, 07:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74144
-
Garvin Hicking voted on patch set 5 CR +1 V +1 02/14/25, 09:00
-
Garvin Hicking voted on patch set 5 CR +2 02/17/25, 09:54
-
Garvin Hicking voted on patch set 5 V +2 02/17/25, 09:54
-
Garvin Hicking merged patch set 6 02/17/25, 09:54