Review main Merged

88192[BUGFIX] Set Background for CKEditor

Benjamin Kott CR +2 V +2 Easy +2 −1 updated 02/12/25, 16:08

Commit message

In previous versions of CKEditor, the content's
CSS was separate from our backend CSS styling.
However, with CKEditor 5, this behavior has
changed, and our CSS now bleeds into the content
area. We have implemented workarounds to mitigate
this issue, aiming to restore the previous
behavior for custom CSS.

Before this patch, the editor inherited the text
color from our backend while explicitly setting
the background color, leading to unreadable text
without custom CSS in dark-mode.

To match backend CSS with the frontend, you must
provide a custom CSS file as before, ensuring it
defines both a text color and background color for
the body. These styles will be rewritten by our
preprocessors to align with the current CKEditor
instance.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Benjamin Kott uploaded patch set 1 02/12/25, 08:09

  2. core-ci voted on patch set 1 V +1 02/12/25, 08:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74032

  3. Andreas Kienast voted on patch set 1 CR +1 V +1 02/12/25, 09:35

  4. Benni Mack voted on patch set 1 CR +1 V +1 02/12/25, 10:29

  5. Benjamin Kott voted on patch set 1 CR +2 V +2 02/12/25, 15:30

  6. Benjamin Kott merged patch set 2 02/12/25, 16:08