88193[TASK] Avoid DataHandler->getRecordProperties() in moveRecord()
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 3
Review log 4781
Show 2856 earlier messages
-
Christian Kuhn uploaded patch set 1 02/12/25, 11:47
-
core-ci voted on patch set 1 V +1 02/12/25, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74038
-
Christian Kuhn uploaded patch set 2
V +102/12/25, 11:58 -
core-ci voted on patch set 2 V +1 02/12/25, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74039
-
Christian Kuhn uploaded patch set 3
V +102/12/25, 14:51 -
core-ci voted on patch set 3 V +1 02/12/25, 14:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74043
-
Christian Kuhn uploaded patch set 4
V +102/12/25, 16:23 -
core-ci voted on patch set 4 V +1 02/12/25, 16:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74049
-
Christian Kuhn uploaded patch set 5
V +102/12/25, 16:40 -
Christian Kuhn uploaded patch set 6 02/12/25, 16:43
-
core-ci voted on patch set 5 V -1 02/12/25, 16:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74051
-
core-ci voted on patch set 6 V -1 02/12/25, 16:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74052
-
Christian Kuhn uploaded patch set 7
V -102/12/25, 16:59 -
Christian Kuhn uploaded patch set 8 02/12/25, 17:08
-
core-ci voted on patch set 7 V -1 02/12/25, 17:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74057
-
Christian Kuhn uploaded patch set 9 02/12/25, 17:16
-
core-ci voted on patch set 8 V -1 02/12/25, 17:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74058
-
core-ci voted on patch set 9 V +1 02/12/25, 17:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74059
-
Christian Kuhn uploaded patch set 10
V +102/12/25, 18:54 -
core-ci voted on patch set 10 V -1 02/12/25, 19:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74064
-
Christian Kuhn uploaded patch set 11
V -102/12/25, 19:13 -
Christian Kuhn uploaded patch set 12 02/12/25, 19:18
-
core-ci voted on patch set 11 V +1 02/12/25, 19:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74065
-
core-ci voted on patch set 12 V -1 02/12/25, 19:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74066
-
Christian Kuhn uploaded patch set 13
V -102/12/25, 19:30 -
core-ci voted on patch set 13 V +1 02/12/25, 19:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74067
-
Christian Kuhn uploaded patch set 14
V +102/12/25, 19:46 -
Christian Kuhn uploaded patch set 15 02/12/25, 19:47
-
core-ci voted on patch set 14 V -1 02/12/25, 19:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74068
-
core-ci voted on patch set 15 V -1 02/12/25, 19:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74069
-
Christian Kuhn uploaded patch set 16
V -102/12/25, 22:11 -
Christian Kuhn uploaded patch set 17 02/12/25, 22:13
-
core-ci voted on patch set 16 V +1 02/12/25, 22:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74070
-
core-ci voted on patch set 17 V +1 02/12/25, 22:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74071
-
Christian Kuhn uploaded patch set 18
V +102/12/25, 23:04 -
core-ci voted on patch set 18 V +1 02/12/25, 23:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74072
-
Christian Kuhn uploaded patch set 19
V +102/12/25, 23:24 -
core-ci voted on patch set 19 V +1 02/12/25, 23:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74073
-
Christian Kuhn uploaded patch set 20
V +102/12/25, 23:33 -
Christian Kuhn uploaded patch set 21 02/12/25, 23:47
-
core-ci voted on patch set 21 V +1 02/12/25, 23:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74075
-
core-ci voted on patch set 20 V +1 02/13/25, 01:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74074
-
Christian Kuhn uploaded patch set 22
V +102/13/25, 22:18 -
core-ci voted on patch set 22 V +1 02/13/25, 22:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74123
-
Christian Kuhn rebased onto patch set 23
V +102/19/25, 17:47 -
core-ci voted on patch set 23 V +1 02/19/25, 17:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74406
-
Christian Kuhn uploaded patch set 24
V +102/19/25, 18:53 -
Christian Kuhn uploaded patch set 25 02/19/25, 18:54
-
core-ci voted on patch set 24 V -1 02/19/25, 19:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74407
-
core-ci voted on patch set 25 V -1 02/19/25, 19:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74408
-
Christian Kuhn uploaded patch set 26
V -102/19/25, 19:29 -
core-ci voted on patch set 26 V -1 02/19/25, 19:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74409
-
Christian Kuhn uploaded patch set 27
V -102/19/25, 19:52 -
core-ci voted on patch set 27 V -1 02/19/25, 20:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74410
-
Christian Kuhn uploaded patch set 28
V -102/20/25, 09:18 -
core-ci voted on patch set 28 V -1 02/20/25, 09:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74454
-
Christian Kuhn uploaded patch set 29
V -102/20/25, 10:00 -
core-ci voted on patch set 29 V +1 02/20/25, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74456
-
Christian Kuhn updated the commit message in patch set 30
V +102/20/25, 10:53 -
core-ci voted on patch set 30 V +1 02/20/25, 10:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74458
-
Benni Mack updated the commit message in patch set 31
V +102/20/25, 11:31 -
Christian Kuhn uploaded patch set 32 02/20/25, 11:35
-
core-ci voted on patch set 31 V +1 02/20/25, 11:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74462
-
core-ci voted on patch set 32 V +1 02/20/25, 11:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74464
-
Christian Kuhn commented on patch set 32 02/20/25, 12:14
-
Christian Kuhn commented on patch set 32 02/20/25, 12:15
DataHandler.php:4448Page is resorted within same parent but user does not have update permissions. -
Benni Mack uploaded patch set 33
V +102/20/25, 15:01 -
Benni Mack voted on patch set 33 CR +1 V +1 02/20/25, 15:01
-
Stefan Bürk commented on patch set 33 CR -1 02/20/25, 15:05
On it .. -
core-ci voted on patch set 33 V +1 02/20/25, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74467
-
Stefan Bürk uploaded patch set 34
CR +1V +102/20/25, 15:41 -
Stefan Bürk commented on patch set 34 02/20/25, 15:41
Reply
DoneDataHandler.php:4442ReplyDoneDataHandler.php:4448ReplyDone -
core-ci voted on patch set 34 V +1 02/20/25, 15:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74470
-
Stefan Bürk voted on patch set 34 CR +1 V +1 02/20/25, 15:55
-
Benni Mack voted on patch set 34 CR +1 V +1 02/20/25, 16:18
-
Andreas Kienast commented on patch set 34 02/20/25, 16:30
DataHandler.php:4353Potential caveat: an extension may provide a table that had workspace fields in the past which have been removed meanwhile from TCA without running the database analyzer and removing the fields. How do we deal with this? Ignore, because DB state isn't clean? -
Benni Mack commented on patch set 34 02/20/25, 16:47
DataHandler.php:4353ReplyThis would be a problem in roughly 250 places... -
Christian Kuhn commented on patch set 34 02/20/25, 17:05
DataHandler.php:4353Replyi docomuneted this scenario in dbdoctor, and it is basically the same with core: core can never know about "previous TCA state". cite from dbdoctor: " dbdoctor always works on the current TCA state. It never knows if some TCA table has been defined "soft-delete-aware" before, and if this has been changed later. When you push records live by removing the "deleted" column, by removing the "workspaces" extension, workspaces related columns, or timing related fields, this can end up with non-repairable state dbdoctor will not be able to fix. Instead, it will tend to find additional database relations that are broken, and will suggest changes that make the situation worse than before. Also, dbdoctor never looks at potentially existing zzz_deleted columns - those do not exist from dbdoctor point of view since they depend on some "before" TCA state that can not be reconstructed again. State created from scenarios like the above ones are not repairable and need manual reconstruction. Good luck. " In addition to that, DH basically expects "most" DB structure to be in sync with TCA - especially new fields. We may catch the one or the other DB exception, but in general, DH (at least currently) expects DB column state is clean. -
Christian Kuhn commented on patch set 34 02/20/25, 17:11
DataHandler.php:4353ReplyThis (sane) limitation is one reason that for instance upgrade wizards mumble when 'new columns' are missing in DB: DH will explode in your hands when DB table/columnn state is not decent. We *may* be able to mitigate this, but that task is definately not scope of this patch, neither it should be. -
Christian Kuhn voted on patch set 34 CR +2 V +2 02/21/25, 09:55
-
Christian Kuhn merged patch set 35 02/21/25, 09:56
DataHandler.php:4442