Review main Merged

88198[TASK] Rebase site set provided TypoScript and label paths to EXT:

Benjamin Franzke CR +2 V +2 Easy +13 −13 updated 02/17/25, 12:00

Commit message

Relative TypoScript and label references in site sets
used to be represented as absolute paths. This resulted
in issues like #105713 and #106115 on windows were
absolute paths use colons and backslashes.

Site site references are now rebased to EXT-paths in
order to enhance compatibility with windows.

As a side-effect the TypoScript includes overview
will now list list EXT:paths instead of absolute paths
in relative imports in site set TypoScript.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1114

  1. Benjamin Franzke uploaded patch set 1 02/12/25, 16:28

  2. core-ci voted on patch set 1 V +1 02/12/25, 16:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74050

  3. Benjamin Franzke uploaded patch set 2 V +1 02/12/25, 16:55

  4. core-ci voted on patch set 2 V +1 02/12/25, 17:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74056

  5. Jörg Bösche voted on patch set 2 CR +1 02/13/25, 08:57

  6. Benjamin Franzke uploaded patch set 3 CR +1 V +1 02/17/25, 10:46

  7. Benjamin Franzke commented on patch set 3 02/17/25, 10:50

    Also tested on windows 11 to ensure this is a suitable replacement for site set label loading on windows https://review.typo3.org/c/Packages/TYPO3.CMS/+/88077 and therefore allows the revert in https://review.typo3.org/c/Packages/TYPO3.CMS/+/88199 to be merged together with this as an alternative fix.
  8. core-ci voted on patch set 3 V +1 02/17/25, 10:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74250

  9. Benjamin Kott voted on patch set 3 CR +1 V +1 02/17/25, 11:27

  10. Andreas Kienast commented on patch set 3 02/17/25, 11:38

    YamlSetDefinitionProvider.php:59

    AFAICS it's not ensured `$virtualSetPath` ends with a slash, this may fail in line 64. This may work better: `$virtualSetPath = ($virtualSetPath ?? $path) . '/';`
  11. Benjamin Franzke commented on patch set 3 02/17/25, 11:43

    YamlSetDefinitionProvider.php:59 Reply

    ack, but this method is internal and `$virtualSetPath` is expected to contain a trailing slash. I'd like to avoid the `rtrim(…, '/') . '/'` dance for internal code.
  12. Andreas Kienast commented on patch set 3 CR +1 V +1 02/17/25, 11:44

    YamlSetDefinitionProvider.php:59 Reply

    Discussed with this bnf, it's internal.
  13. Benjamin Franzke voted on patch set 3 CR +2 V +2 02/17/25, 11:53

  14. Benjamin Franzke merged patch set 4 02/17/25, 12:00