88198[TASK] Rebase site set provided TypoScript and label paths to EXT:
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benjamin Kott +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benjamin Kott +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1114
-
Benjamin Franzke uploaded patch set 1 02/12/25, 16:28
-
core-ci voted on patch set 1 V +1 02/12/25, 16:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74050
-
Benjamin Franzke uploaded patch set 2
V +102/12/25, 16:55 -
core-ci voted on patch set 2 V +1 02/12/25, 17:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74056
-
Jörg Bösche voted on patch set 2 CR +1 02/13/25, 08:57
-
Benjamin Franzke uploaded patch set 3
CR +1V +102/17/25, 10:46 -
Benjamin Franzke commented on patch set 3 02/17/25, 10:50
Also tested on windows 11 to ensure this is a suitable replacement for site set label loading on windows https://review.typo3.org/c/Packages/TYPO3.CMS/+/88077 and therefore allows the revert in https://review.typo3.org/c/Packages/TYPO3.CMS/+/88199 to be merged together with this as an alternative fix. -
core-ci voted on patch set 3 V +1 02/17/25, 10:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74250
-
Benjamin Kott voted on patch set 3 CR +1 V +1 02/17/25, 11:27
-
Andreas Kienast commented on patch set 3 02/17/25, 11:38
YamlSetDefinitionProvider.php:59AFAICS it's not ensured `$virtualSetPath` ends with a slash, this may fail in line 64. This may work better: `$virtualSetPath = ($virtualSetPath ?? $path) . '/';` -
Benjamin Franzke commented on patch set 3 02/17/25, 11:43
YamlSetDefinitionProvider.php:59Replyack, but this method is internal and `$virtualSetPath` is expected to contain a trailing slash. I'd like to avoid the `rtrim(…, '/') . '/'` dance for internal code. -
Andreas Kienast commented on patch set 3 CR +1 V +1 02/17/25, 11:44
YamlSetDefinitionProvider.php:59ReplyDiscussed with this bnf, it's internal. -
Benjamin Franzke voted on patch set 3 CR +2 V +2 02/17/25, 11:53
-
Benjamin Franzke merged patch set 4 02/17/25, 12:00