Review main Merged

88199[BUGFIX] Revert "[BUGFIX] Fix site set label loading on windows"

Benjamin Franzke CR +2 V +2 Easy +13 −37 updated 02/17/25, 11:59

Commit message

This reverts commit a84d9ddd305fad3db7e22341faf012b37bb56526.

Reason for revert:
Until v13.4.4 a backend module title could be loaded from a slightly
invalid config in `Configuration/Backend/Modules.php` like:

```
'labels' => 'LLL:EXT:myext/…/locallang.xlf:my.title'
```

Although `'labels'` is supposed to contain a file reference only
(like `LLL:EXT:myext/Resources/Private/Language/locallang.xlf`)
the example above worked because TYPO3 built a language key named
`LLL:EXT:myext/…/locallang.xlf:my.title:mlang_tabs_tab`
where `:mlang_tabs_tab` then was ignored by the LLL: parser in
`LanguageService`, because it implicitly ignores everything after
the second colon after `LLL:EXT:`.

That means we can not assume that the language key is listed after
the last colon, as existing (undefined) behaviour silently ignored
gratuitous colon-suffixes. Multiple public extensions where found
that use this approach, therefore we revert this change and plan
to fix windows site label loading using another approach. (#106164)

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 710

  1. Benjamin Franzke uploaded patch set 1 02/12/25, 16:43

  2. Benjamin Franzke uploaded patch set 2 02/12/25, 16:47

  3. core-ci voted on patch set 1 V +1 02/12/25, 16:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74053

  4. Benjamin Franzke updated the commit message in patch set 3 02/12/25, 16:55

  5. core-ci voted on patch set 2 V +1 02/12/25, 16:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74054

  6. core-ci voted on patch set 3 V +1 02/12/25, 17:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74055

  7. Benjamin Kott voted on patch set 3 CR +1 V +1 02/17/25, 11:29

  8. Andreas Kienast voted on patch set 3 CR +1 V +1 02/17/25, 11:42

  9. Benjamin Franzke voted on patch set 3 CR +2 V +2 02/17/25, 11:43

  10. Benjamin Franzke merged patch set 4 02/17/25, 11:59