Review main Merged

88205[TASK] Enable TypeScript `noImplicitOverride` option

Benjamin Franzke CR +2 V +2 Hard +367 −359 updated 02/17/25, 12:09

Commit message

Enforce declaration of the `override` keyword for methods or
properties that override members of a base class, to ensure
that base classes and extending classes never get "out of sync".

See also: https://www.typescriptlang.org/tsconfig/#noImplicitOverride

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 118

Show 98 more files

Review log 56

  1. Benjamin Franzke uploaded patch set 1 02/13/25, 11:05

  2. core-ci voted on patch set 1 V +1 02/13/25, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74110

  3. Georg Ringer voted on patch set 1 CR +1 V +1 02/16/25, 19:01

  4. Andreas Kienast voted on patch set 1 CR +1 V +1 02/17/25, 11:46

  5. Benjamin Franzke voted on patch set 1 CR +2 V +2 02/17/25, 12:03

  6. Benjamin Franzke merged patch set 2 02/17/25, 12:09