88206[BUGFIX] Fix failing image generation for width/height 0 thumbnails
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oliver Klee +1
-
Verified V +2 Done
- Georg Ringer +2
- Oliver Klee +1
- core-ci +1 CI
Issues 4
- Bug #106169Creating 64x64 thumbnails with extreme proportions may fail
- Bug #106094Exception in ImageProcessingInstructions if calculated maxWidth is float
- Task #106166ImageProcessing exception for width/height=0 asks for reporting but misses important details
- Task #103351Avoid duplicate image crop (crop-crop-scale to crop-scale)
Files 2
Review log 1218
-
Garvin Hicking uploaded patch set 1 02/13/25, 12:11
-
core-ci voted on patch set 1 V +1 02/13/25, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74111
-
Oliver Klee commented on patch set 1 02/13/25, 12:25
-
Garvin Hicking uploaded patch set 2
V +102/13/25, 12:55 -
Garvin Hicking commented on patch set 2 02/13/25, 12:57
ImageProcessingInstructions.php:181ReplyNice! I was trying to think of a smaller footprint here but was too unimaginative. Implemented it with max() - I switched the order because this way it's easier for me to see that it will be a minimum of '1'. Also, added tests now to verify the new behavior (which would also fail on the old codebase). -
Garvin Hicking commented on patch set 3 02/13/25, 12:58
Published edit on patch set 2. -
Oliver Klee voted on patch set 3 CR +1 V +1 02/13/25, 13:00
-
core-ci voted on patch set 2 V +1 02/13/25, 13:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74112
-
core-ci voted on patch set 3 V +1 02/13/25, 13:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74113
-
Garvin Hicking commented on patch set 4
CR +1V +102/15/25, 10:18Published edit on patch set 3. -
Garvin Hicking updated the commit message in patch set 5 02/15/25, 10:19
-
core-ci voted on patch set 4 V -1 02/15/25, 10:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74176
-
core-ci voted on patch set 5 V -1 02/15/25, 10:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74177
-
Garvin Hicking uploaded patch set 6
V -102/15/25, 12:07 -
core-ci voted on patch set 6 V +1 02/15/25, 12:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74178
-
Oliver Klee voted on patch set 6 CR +1 V +1 02/15/25, 13:56
-
Georg Ringer voted on patch set 6 CR +2 V +2 02/16/25, 18:38
-
Georg Ringer merged patch set 7 02/16/25, 18:38
ImageProcessingInstructions.php:181