88212[BUGFIX] Guard modal access to prevent same-origin policy errors
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
- Oliver Hader +1
- Benni Mack +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
- Oliver Hader +1
- Benni Mack +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 3
Files 2
Review log 1417
-
Garvin Hicking uploaded patch set 1 02/13/25, 23:03
-
core-ci voted on patch set 1 V +1 02/13/25, 23:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74124
-
Oliver Hader commented on patch set 1 02/14/25, 10:30
I'll push an updated version soon..element-browser.ts:96This is the only relevant part, when `item` might be a restricted cross-origin frame, injected by other browser extensions. -
Oliver Hader uploaded patch set 2
V +102/14/25, 10:46 -
Oliver Hader commented on patch set 2 02/14/25, 10:47
element-browser.ts:96ReplyDone -
core-ci voted on patch set 2 V +1 02/14/25, 10:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74145
-
Oliver Hader updated the commit message in patch set 3
V +102/14/25, 10:55 -
Oliver Hader voted on patch set 3 CR +1 V +1 02/14/25, 10:56
-
core-ci voted on patch set 3 V +1 02/14/25, 11:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74146
-
Benni Mack voted on patch set 3 CR +1 V +1 02/14/25, 11:11
-
Stefan Bürk voted on patch set 3 CR +1 02/14/25, 11:17
-
Stefan Bürk voted on patch set 3 V +1 02/14/25, 11:19
-
Simon Schaufelberger voted on patch set 3 CR +1 V +1 02/14/25, 11:28
-
Oli Bartsch commented on patch set 3 CR -1 02/17/25, 09:38
Reviewing -
Oli Bartsch voted on patch set 3 CR +2 V +2 02/17/25, 09:57
-
Oli Bartsch merged patch set 4 02/17/25, 09:57
-
Oliver Hader commented on patch set 4 02/17/25, 10:08
Reply
Done