Review main Merged

88215[TASK] Enable TypeScript `noUnusedLocals` option

Benjamin Franzke CR +2 V +2 Normal +20 −65 updated 02/20/25, 12:27

Commit message

Disallow unused variables or unused private methods to reduce
the level of code smell in our codebase.

See also: https://www.typescriptlang.org/tsconfig/#noUnusedLocals

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 23

Show 3 more files

Review log 1115

  1. Benjamin Franzke uploaded patch set 1 02/14/25, 06:31

  2. core-ci voted on patch set 1 V -1 02/14/25, 06:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74139

  3. Benjamin Franzke uploaded patch set 2 V -1 02/17/25, 10:34

  4. core-ci voted on patch set 2 V +1 02/17/25, 10:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74244

  5. Benjamin Franzke uploaded patch set 3 V +1 02/17/25, 19:32

  6. core-ci voted on patch set 3 V +1 02/17/25, 19:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74264

  7. Andreas Kienast commented on patch set 3 02/18/25, 06:09

    admin-panel.ts:50

    AFAICS `map()` now returns unused instances of `AdminPanelPanel` and `AdminPanelContentSetting` respectively. Either removing `return` or using a classic loop makes it IMO clear that there's more magic going on.
  8. Benjamin Franzke commented on patch set 3 CR -1 02/18/25, 07:45

    admin-panel.ts:50 Reply

    ack, `.forEach` without `return` would be better now
  9. Benjamin Franzke uploaded patch set 4 CR -1 V +1 02/18/25, 08:12

  10. Benjamin Franzke commented on patch set 4 02/18/25, 08:12

    admin-panel.ts:50 Reply

    Done
  11. core-ci voted on patch set 4 V +1 02/18/25, 08:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74297

  12. Andreas Kienast voted on patch set 4 CR +1 V +1 02/20/25, 08:00

  13. Oli Bartsch voted on patch set 4 CR +1 V +1 02/20/25, 11:03

  14. Benjamin Franzke voted on patch set 4 CR +2 V +2 02/20/25, 12:04

  15. Benjamin Franzke merged patch set 5 02/20/25, 12:27