Review main Merged

88216[TASK] Enable most TypeScript strict-mode options

Benjamin Franzke CR +2 V +2 Easy +16 −10 updated 02/28/25, 15:16

Commit message

We can not yet enable strictNullChecks [1] (>2000 errors),
but three other sub-options of the `strict` [2] flag are
now being enabled, where only a minimum amount of changes
are needed:

 * `strictBindCallApply` (2 changes)
 * `useUnknownInCatchVariables` option (3 changes)
 * `strictBuiltinIteratorReturn` (0 changes)

[1] https://www.typescriptlang.org/tsconfig/#strictNullChecks
[2] https://www.typescriptlang.org/tsconfig/#strict

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1014

  1. Benjamin Franzke uploaded patch set 1 02/14/25, 06:31

  2. core-ci voted on patch set 1 V -1 02/14/25, 06:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74140

  3. Benjamin Franzke uploaded patch set 2 V -1 02/17/25, 10:34

  4. core-ci voted on patch set 2 V +1 02/17/25, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74245

  5. Benjamin Franzke uploaded patch set 3 V +1 02/20/25, 07:24

  6. core-ci voted on patch set 3 V +1 02/20/25, 07:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74440

  7. Andreas Kienast voted on patch set 3 CR +1 V +1 02/20/25, 14:02

  8. Simon Schaufelberger voted on patch set 3 CR +1 V +1 02/28/25, 00:51

  9. Benjamin Franzke uploaded patch set 4 CR +1 V +1 02/28/25, 08:02

  10. Andreas Kienast voted on patch set 4 CR +1 V +1 02/28/25, 08:04

  11. core-ci voted on patch set 4 V +1 02/28/25, 08:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74868

  12. Simon Schaufelberger voted on patch set 4 CR +1 V +1 02/28/25, 12:54

  13. Benjamin Franzke voted on patch set 4 CR +2 V +2 02/28/25, 15:16

  14. Benjamin Franzke merged patch set 5 02/28/25, 15:16