Review main Merged

88230[BUGFIX] Fix TypeError when switching workspaces without selected module

Benjamin Franzke CR +2 V +2 Easy +2 −2 updated 02/17/25, 07:01

Commit message

Handle null values returned by `ModuleMenu.App.getCurrentModule()`.

That's the case when no module is selected in the module menu,
e.g. when refreshing the TYPO3 backend in FormEngine context.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Benjamin Franzke uploaded patch set 1 02/15/25, 15:20

  2. core-ci voted on patch set 1 V +1 02/15/25, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74183

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 02/16/25, 16:38

  4. Benni Mack voted on patch set 1 CR +1 V +1 02/16/25, 21:10

  5. Andreas Kienast voted on patch set 1 CR +2 V +2 02/17/25, 06:31

  6. Andreas Kienast merged patch set 2 02/17/25, 07:01