Review main Merged

88243[DOCS] Additional check fields in Link Validator manual

Lina Wolf CR +2 V +2 Normal +97 −33 updated 02/20/25, 08:41

Commit message

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1218

  1. Lina Wolf uploaded patch set 1 02/17/25, 08:41

  2. Lina Wolf updated the commit message in patch set 2 02/17/25, 08:42

  3. Lina Wolf updated the commit message in patch set 3 02/17/25, 08:43

  4. core-ci voted on patch set 1 V +1 02/17/25, 08:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74237

  5. core-ci voted on patch set 2 V +1 02/17/25, 08:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74238

  6. core-ci voted on patch set 3 V +1 02/17/25, 08:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74239

  7. Garvin Hicking commented on patch set 3 02/17/25, 09:26

    Index.rst:95

    IMO it would be good to keep an example showing that default values can be overwritten and must not necessarily be appended through `addToList()`? Maybe add an inline comment like ``` # Usually you want to append fields: tt_content := addToList(mysitepackage_carousel_morelink) # or you can set specific columns (overwriting defaults): # tt_content = bodytext ``` ?

    Index.rst:351

    ```suggestion Additionally, email reports and the HTTP agent for external URLS are configured. ```
  8. Lina Wolf commented on patch set 4 V +1 02/18/25, 05:31

    Published edit on patch set 3.
  9. Lina Wolf commented on patch set 5 02/18/25, 05:33

    Published edit on patch set 4.
  10. Lina Wolf commented on patch set 5 02/18/25, 05:33

    Index.rst:95 Reply

    Done

    Index.rst:351 Reply

    Done
  11. core-ci voted on patch set 4 V +1 02/18/25, 05:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74290

  12. core-ci voted on patch set 5 V +1 02/18/25, 05:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74291

  13. Garvin Hicking commented on patch set 6 V +1 02/18/25, 06:14

    Published edit on patch set 5.
  14. Garvin Hicking voted on patch set 6 CR +1 V +1 02/18/25, 06:14

  15. core-ci voted on patch set 6 V +1 02/18/25, 06:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74295

  16. Christian Kuhn voted on patch set 6 CR +1 V +1 02/19/25, 17:45

  17. Garvin Hicking voted on patch set 6 CR +2 V +2 02/20/25, 08:15

  18. Garvin Hicking merged patch set 7 02/20/25, 08:41