Review main Merged

88244[TASK] Add tests for RteHtmlParser and HtmlParser YAML coverage

Garvin Hicking CR +2 V +2 Expert +1210 −0 updated 02/28/25, 17:14

Commit message

Both RteHtmlParser and HtmlParser had no coverage for 'fixAttribs'
functionality (and 'blockElements', 'denyTags', 'casesensitiveComp').

This patch adds tests to verify these can be performed, in both
TypoScript or RTE YAML Preset "processing" modes.

These tests also reveal issues in array vs. string handling,
the YAML parsing is missing to allow some directives
(fixAttribs.list and fixAttribs.range most notable) to be
specified in either string or array notation. This is
addressed in a seperate bugfix #92943.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • Simon Schaufelberger +1
    • Benni Mack +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 7

Review log 1115

  1. Garvin Hicking uploaded patch set 1 02/17/25, 09:37

  2. Garvin Hicking marked it work in progress 02/17/25, 09:37

  3. core-ci voted on patch set 1 V -1 02/17/25, 09:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74240

  4. Garvin Hicking uploaded patch set 2 V -1 02/17/25, 10:07

  5. core-ci voted on patch set 2 V -1 02/17/25, 10:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74243

  6. Garvin Hicking uploaded patch set 3 V -1 02/17/25, 16:43

  7. core-ci voted on patch set 3 V -1 02/17/25, 16:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74258

  8. Garvin Hicking uploaded patch set 4 V -1 02/17/25, 16:58

  9. core-ci voted on patch set 4 V +1 02/17/25, 17:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74259

  10. Garvin Hicking marked it ready for review 02/17/25, 18:09

  11. Georg Ringer voted on patch set 4 CR +1 V +1 02/17/25, 18:43

  12. Simon Schaufelberger voted on patch set 4 CR +1 V +1 02/18/25, 00:08

  13. Benni Mack voted on patch set 4 CR +1 02/18/25, 14:44

  14. Garvin Hicking voted on patch set 4 CR +2 V +2 02/28/25, 17:14

  15. Garvin Hicking merged patch set 5 02/28/25, 17:14