88247[TASK] Avoid global TYPO3 namespace in adminpanel JavaScript
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
- Andreas Kienast +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Christian Kuhn +1
- Andreas Kienast +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 6
- Build/Sources/TypeScript/adminpanel/modules/cache.ts+3 −6
- Build/Sources/TypeScript/adminpanel/modules/preview.ts+3 −6
- Build/Sources/TypeScript/adminpanel/admin-panel.ts2+5 −8
- typo3/sysext/adminpanel/Resources/Public/JavaScript/modules/cache.js+1 −1
- typo3/sysext/adminpanel/Resources/Public/JavaScript/modules/preview.js+1 −1
- typo3/sysext/adminpanel/Resources/Public/JavaScript/admin-panel.js+1 −1
Review log 1621
-
Benjamin Franzke uploaded patch set 1 02/17/25, 10:34
-
core-ci voted on patch set 1 V +1 02/17/25, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74248
-
Benjamin Franzke uploaded patch set 2
V +102/20/25, 07:24 -
core-ci voted on patch set 2 V +1 02/20/25, 07:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74441
-
Benjamin Franzke uploaded patch set 3
V +103/04/25, 11:17 -
core-ci voted on patch set 3 V +1 03/04/25, 11:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75093
-
Andreas Kienast commented on patch set 3 03/04/25, 11:25
-
Benjamin Franzke uploaded patch set 4
V +103/04/25, 11:30 -
Benjamin Franzke commented on patch set 4 03/04/25, 11:30
admin-panel.ts:1Replyno, happened because I moved the code into the IIFE at the end of the file (looks like new code in the diff), and the files just used to use different IIFE's. Streamlined to fat arrow. -
core-ci voted on patch set 4 V +1 03/04/25, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75095
-
Benni Mack voted on patch set 4 CR +1 V +1 03/04/25, 12:19
-
Garvin Hicking commented on patch set 4 03/04/25, 19:22
"pollute", not wanting to force a revote for this though ;) -
Benjamin Franzke uploaded patch set 5
CR +1V +103/05/25, 03:18 -
Benjamin Franzke commented on patch set 5 03/05/25, 03:18
Reply
no worries, fixed! now we have to revote :) -
core-ci voted on patch set 5 V +1 03/05/25, 03:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75118
-
Garvin Hicking voted on patch set 5 CR +1 03/05/25, 05:59
-
Christian Kuhn voted on patch set 5 V +1 03/05/25, 06:15
-
Andreas Kienast voted on patch set 5 CR +1 V +1 03/05/25, 07:37
-
Benni Mack voted on patch set 5 CR +1 V +1 03/05/25, 07:38
-
Benjamin Franzke voted on patch set 5 CR +2 V +2 03/05/25, 07:55
-
Benjamin Franzke merged patch set 6 03/05/25, 08:19
admin-panel.ts:1