Review main Merged

88247[TASK] Avoid global TYPO3 namespace in adminpanel JavaScript

Benjamin Franzke CR +2 V +2 Easy +14 −23 updated 03/05/25, 08:19

Commit message

Exporting to a global namespace is not supported
with https://www.typescriptlang.org/tsconfig/#verbatimModuleSyntax
and we actually do not need to pollute the `TYPO3` global object with
admin-panel JavaScript.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1621

  1. Benjamin Franzke uploaded patch set 1 02/17/25, 10:34

  2. core-ci voted on patch set 1 V +1 02/17/25, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74248

  3. Benjamin Franzke uploaded patch set 2 V +1 02/20/25, 07:24

  4. core-ci voted on patch set 2 V +1 02/20/25, 07:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74441

  5. Benjamin Franzke uploaded patch set 3 V +1 03/04/25, 11:17

  6. core-ci voted on patch set 3 V +1 03/04/25, 11:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75093

  7. Andreas Kienast commented on patch set 3 03/04/25, 11:25

    admin-panel.ts:1

    Any reason we go with `function` here, unlike in the other changed files?
  8. Benjamin Franzke uploaded patch set 4 V +1 03/04/25, 11:30

  9. Benjamin Franzke commented on patch set 4 03/04/25, 11:30

    admin-panel.ts:1 Reply

    no, happened because I moved the code into the IIFE at the end of the file (looks like new code in the diff), and the files just used to use different IIFE's. Streamlined to fat arrow.
  10. core-ci voted on patch set 4 V +1 03/04/25, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75095

  11. Benni Mack voted on patch set 4 CR +1 V +1 03/04/25, 12:19

  12. Garvin Hicking commented on patch set 4 03/04/25, 19:22

    "pollute", not wanting to force a revote for this though ;)
  13. Benjamin Franzke uploaded patch set 5 CR +1 V +1 03/05/25, 03:18

  14. Benjamin Franzke commented on patch set 5 03/05/25, 03:18

    Reply

    no worries, fixed! now we have to revote :)
  15. core-ci voted on patch set 5 V +1 03/05/25, 03:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75118

  16. Garvin Hicking voted on patch set 5 CR +1 03/05/25, 05:59

  17. Christian Kuhn voted on patch set 5 V +1 03/05/25, 06:15

  18. Andreas Kienast voted on patch set 5 CR +1 V +1 03/05/25, 07:37

  19. Benni Mack voted on patch set 5 CR +1 V +1 03/05/25, 07:38

  20. Benjamin Franzke voted on patch set 5 CR +2 V +2 03/05/25, 07:55

  21. Benjamin Franzke merged patch set 6 03/05/25, 08:19