Review main Merged

88252[TASK] Update external libraries table

Andreas Kienast CR +2 V +2 Easy +11 −11 updated 03/27/25, 13:53

Commit message

The following libraries have been removed from the listing as they have
been removed in recent TYPO3 versions:

* jQuery UI
* moment.js

The following library has been added:

* Lit
* chart.js

Also, some names have been adjusted.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benjamin Franzke +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benjamin Franzke +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1721

  1. Andreas Kienast uploaded patch set 1 02/17/25, 12:54

  2. core-ci voted on patch set 1 V +1 02/17/25, 13:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74256

  3. Benjamin Franzke commented on patch set 1 02/17/25, 13:17

    I also found following js libs that we ship in Contrib/ folders: * chartjs * css-tree * dompurify * interact * lodash (as dependency of ckeditor) * mark * marked * sortablejs * style-mod * w3c-keyname Should/do we need to list all of them(?) Found via: ``` git grep "Contrib/.*js" typo3/sysext/*/Configuration/JavaScriptModules.php | sed "s:.*Contrib/\([^/]*\)\(/.*\|.js',\)$:\1:" | sort | uniq ```

    ExternalLibraries.html:139

  4. Andreas Kienast commented on patch set 1 02/17/25, 13:51

    Reply

    I wonder whether we can autogenerate this somehow from our composer.json / package.json files.
  5. Benni Mack commented on patch set 1 03/04/25, 12:30

    Reply

    we don't need to do this at all. I'm fine with updating the list as you proposed, and list only "major" dependencies in v14. - Doctrine - Symfony Components - Lit - jQuery - Twitter Bootstrap and then a complete list (auto-generated from composer.json and package.json) as a simple bullet list.
  6. Andreas Kienast uploaded patch set 2 V +1 03/10/25, 08:46

  7. Andreas Kienast commented on patch set 2 03/10/25, 08:46

    I've set the patch as WIP now. I'm not sure about the listing, it looks like "nice try".
  8. core-ci voted on patch set 2 V -1 03/10/25, 08:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75394

  9. Andreas Kienast commented on patch set 2 03/25/25, 09:01

    Could I please get some feedback here?
  10. Benni Mack commented on patch set 2 03/25/25, 09:18

    Reply

    Please don't put any energy in doing some "automation" from composer.json or npm/package.lock.... I am fine with this change, but in the future, I hope we get SBOM and could do some automation via SBOM: https://github.com/sbominator/sbom-typo3
  11. Andreas Kienast uploaded patch set 3 V -1 03/27/25, 13:12

  12. core-ci voted on patch set 3 V +1 03/27/25, 13:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76456

  13. Benni Mack commented on patch set 3 03/27/25, 13:22

    ExternalLibraries.html:139 Reply

    Done
  14. Benni Mack commented on patch set 3 03/27/25, 13:22

    Reply

    Done
  15. Benni Mack commented on patch set 3 CR +1 03/27/25, 13:23

    Reply

    Done
  16. Benni Mack uploaded patch set 4 CR +1 V +1 03/27/25, 13:25

  17. Benni Mack commented on patch set 4 CR +1 V +1 03/27/25, 13:25

    Cropper.js now has also been updated
  18. core-ci voted on patch set 4 V +1 03/27/25, 13:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76457

  19. Benjamin Franzke commented on patch set 4 CR +1 V +1 03/27/25, 13:46

    Reply

    Done
  20. Georg Ringer voted on patch set 4 CR +2 V +2 03/27/25, 13:53

  21. Georg Ringer merged patch set 5 03/27/25, 13:53