Review main Abandoned

88254[TASK] Use native @interactjs/interactjs ES6 package

Benjamin Franzke CR 0 V 0 Hard +399 −45 updated 02/18/25, 12:18

Commit message

Build a native ES6 module from the @interactjs/interactjs sources as
suggested to be used for native ES6 module environments in:
https://github.com/taye/interact.js/issues/769

The advantage of using `@interactjs/interactjs` instead of
`interactjs` is that the shipped typescript types can
be used instead of the CommonJS targeted wrapper types from
`@interactjs/types` which are not compatible with the
`verbatimModuleSyntax` [1] TypeScript option that we'd like to
enable in future.

This change also means one less package needs our custom CommonJS-to-ES6
wrapper which is actually a workaround intended for packages that do not
provide any usable ES6 modules upstream.

Commands executed:
  npm remove interactjs
  npm install @interactjs/interactjs
  npm run build

[1] https://www.typescriptlang.org/tsconfig/#verbatimModuleSyntax

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 11

Review log 1011

  1. Benjamin Franzke uploaded patch set 1 02/17/25, 19:23

  2. Benjamin Franzke commented on patch set 1 02/17/25, 19:26

    JavaScriptModules.php:19 Unresolved

    The 13.4 backport will not drop this import (in case any extension used this internal library directly), it will add a link to the new filename (which is still compatible, as our cjs-to-esm wrapper already produced a ESM module from the cjs-wrapper for the upstream esm-module), mathematically speaking: `ESM(CJS(ESM)) = ESM` ``` 'interactjs' => 'EXT:core/Resources/Public/JavaScript/Contrib/@interactjs/interactjs.js' ```
  3. core-ci voted on patch set 1 V +1 02/17/25, 19:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74263

  4. Andreas Kienast commented on patch set 1 02/18/25, 06:04

    package-lock.json:4560

    Do you know where all the `@vue/*` stuff comes from? I couldn't find those as a dependency on npmjs.com.
  5. Benni Mack commented on patch set 1 02/18/25, 07:47

    package-lock.json:4560 Reply

    coming from "@interactjs/dev-tools"
  6. Andreas Kienast commented on patch set 1 CR +1 02/18/25, 07:51

    package-lock.json:4560 Reply

    Thanks. Now I know I cannot trust the count in the tab as it doesn't include dev dependencies... (https://www.npmjs.com/package/@interactjs/dev-tools?activeTab=dependencies).
  7. Benjamin Franzke commented on patch set 1 CR -2 02/18/25, 08:16

    package-lock.json:4560 Reply

    sucks indeed…
  8. Benjamin Franzke marked it work in progress 02/18/25, 08:16

  9. Benjamin Franzke marked it ready for review 02/18/25, 12:17

  10. Benjamin Franzke abandoned the change 02/18/25, 12:18

  11. Benjamin Franzke commented on patch set 1 02/18/25, 12:18

    package-lock.json:4560 Reply Unresolved

    I'm going to remove interactjs instead… https://review.typo3.org/c/Packages/TYPO3.CMS/+/88260