88254[TASK] Use native @interactjs/interactjs ES6 package
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 11
- Build/rollup/config.js+2 −0
- Build/rollup/interactjs.jsnew+24 −0
- Build/Sources/TypeScript/viewpage/main.ts+2 −2
- Build/Gruntfile.js+0 −1
- Build/package-lock.json5+366 −31
- Build/package.json+1 −1
- Build/web-test-runner.config.mjs+1 −1
- typo3/sysext/core/Configuration/JavaScriptModules.php1+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@interactjs/interactjs.jsnew+1 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/interact.jsdeleted+0 −7
- typo3/sysext/viewpage/Resources/Public/JavaScript/main.js+1 −1
Review log 1011
-
Benjamin Franzke uploaded patch set 1 02/17/25, 19:23
-
Benjamin Franzke commented on patch set 1 02/17/25, 19:26
-
core-ci voted on patch set 1 V +1 02/17/25, 19:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74263
-
Andreas Kienast commented on patch set 1 02/18/25, 06:04
package-lock.json:4560Do you know where all the `@vue/*` stuff comes from? I couldn't find those as a dependency on npmjs.com. -
Benni Mack commented on patch set 1 02/18/25, 07:47
package-lock.json:4560Replycoming from "@interactjs/dev-tools" -
Andreas Kienast commented on patch set 1 CR +1 02/18/25, 07:51
package-lock.json:4560ReplyThanks. Now I know I cannot trust the count in the tab as it doesn't include dev dependencies... (https://www.npmjs.com/package/@interactjs/dev-tools?activeTab=dependencies). -
Benjamin Franzke commented on patch set 1 CR -2 02/18/25, 08:16
package-lock.json:4560Replysucks indeed… -
Benjamin Franzke marked it work in progress 02/18/25, 08:16
-
Benjamin Franzke marked it ready for review 02/18/25, 12:17
-
Benjamin Franzke abandoned the change 02/18/25, 12:18
-
Benjamin Franzke commented on patch set 1 02/18/25, 12:18
package-lock.json:4560Reply UnresolvedI'm going to remove interactjs instead… https://review.typo3.org/c/Packages/TYPO3.CMS/+/88260
JavaScriptModules.php:19Unresolved