88256[TASK] Remove 'center' and 'font' tags in RTE processing
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Georg Ringer +1
- Oliver Wand +1
- Benni Mack +1
-
Verified V +2 Done
- Garvin Hicking +2
- Georg Ringer +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 4
- typo3/sysext/core/Documentation/Changelog/14.0/Important-106192-AddCenterAndFontToYamlProcessingRemoveTags.rst3new+65 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/SecurityTest.php+9 −9
- typo3/sysext/rte_ckeditor/Configuration/RTE/Processing.yaml+1 −2
- typo3/sysext/rte_ckeditor/Tests/Functional/HtmlParser/HtmlParserProcessingTest.php+2 −0
Review log 2227
Show 2 earlier messages
-
core-ci voted on patch set 1 V +1 02/18/25, 08:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74296
-
Garvin Hicking commented on patch set 1 02/18/25, 08:30
Breaking-106192-AddCenterAndFontToYamlProcessingRemoveTags.rst:64ReplyHm, I thought this was clear. How about: ``` The tags 'center' and 'font' could be configured via the `editor.conf.style.definitions` option (not set by default). This would allow the CKEditor to place 'center' and 'font' tags. However, when the tags are also listed in `removeTags` (now default), these tags would be removed when saving. ``` If you can provide an alternate wording for this that phrases this more precisely, I'd be happy to use that. -
Benni Mack commented on patch set 1 02/18/25, 13:00
IMHO, this is not "breaking" but rather "important". Why? the API does not break, but people should have a note (doc) that - if they use it - they need to add this to their config again. -
Garvin Hicking commented on patch set 1 02/18/25, 13:06
Reply
Hm. I would argue that people lose current content with this change. I would argue anything that goes missing or a change in established/expectged behaviour would be documented as a breaking change. Having said that: I could change this to "important" of course, it is a rather "edgy" case, and these tags should have been removed since some time already, if the directive wasn't buggy. Let me sleep on it. -
Benni Mack commented on patch set 1 02/18/25, 13:13
Reply
They only loose content if the open + close an existing content (and that's what I see as Important, but not breaking) -
Oliver Wand voted on patch set 1 CR +1 02/18/25, 14:19
-
Garvin Hicking uploaded patch set 2
CR +1V +102/19/25, 11:29 -
Garvin Hicking commented on patch set 2 02/19/25, 11:29
Reply
I moved it from breaking to important now.Breaking-106192-AddCenterAndFontToYamlProcessingRemoveTags.rst:64ReplyI changed this now and hope it's better. -
core-ci voted on patch set 2 V +1 02/19/25, 11:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74378
-
Benni Mack commented on patch set 2 CR -1 02/19/25, 11:43
Important-106192-AddCenterAndFontToYamlProcessingRemoveTags.rst:17this is wrong. Please understand the different parts. RTEparseFunc (I think you mean lib.parseFunc_RTE) has nothing to do with RteHtmlParser, or the Processing.yaml or the RTE configuration. It just has a similar name. the RTE yaml configuration is there to describe a) what features/configuration the editor should have b) what the transformations / processing should do when reading content from the DB TO the RTE and vice versa (_rte and _db suffixes). This is crucial because this depends what is stripped away. lib.parseFunc_RTE allows to change, remove or add things when rendering content. For this: I personally would remove any information on lib.parseFunc_RTE. When rendering, the font tag still might be rendered because it is still in lib.parseFunc_RTE allowedTags / deniedTags (in FSC it is still included in the constants, but not used). -
Garvin Hicking commented on patch set 3
CR -1V +102/19/25, 11:50Published edit on patch set 2. -
Garvin Hicking commented on patch set 3 02/19/25, 11:51
Important-106192-AddCenterAndFontToYamlProcessingRemoveTags.rst:17ReplyYes, you are right of course. I got side-tracked due to my YAML processing parsing efforts to harmonize TypoScript and YAML usage. Could you check if that fits better with you? Else I'm very open to any re-phrasing you see fit, please go ahead. -
core-ci voted on patch set 3 V +1 02/19/25, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74381
-
Benni Mack commented on patch set 4
V +102/19/25, 12:23Published edit on patch set 3. -
Benni Mack commented on patch set 4 02/19/25, 12:24
Should we link to https://developer.mozilla.org/en-US/docs/Web/HTML/Element/font to demonstrate that this is deprecated? -
Garvin Hicking commented on patch set 5 02/19/25, 12:28
Published edit on patch set 4. -
Garvin Hicking commented on patch set 5 02/19/25, 12:29
Reply
Yes. :) -
core-ci voted on patch set 4 V +1 02/19/25, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74383
-
core-ci voted on patch set 5 V +1 02/19/25, 12:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74384
-
Oliver Wand voted on patch set 5 CR +1 02/19/25, 12:55
-
Benni Mack commented on patch set 5 CR +1 V +1 02/19/25, 13:45
Important-106192-AddCenterAndFontToYamlProcessingRemoveTags.rst:17ReplyDone -
Georg Ringer voted on patch set 5 CR +1 V +1 02/21/25, 16:59
-
Garvin Hicking voted on patch set 5 CR +2 V +2 02/24/25, 08:21
-
Garvin Hicking merged patch set 6 02/24/25, 08:22
-
Lina Wolf commented on patch set 6 03/29/25, 09:53
I think this should also be documented in the RTE manual. See also https://github.com/TYPO3-Documentation/Changelog-To-Doc/issues/1204 Help wanted.
Breaking-106192-AddCenterAndFontToYamlProcessingRemoveTags.rst:64