Review main Merged

88257[BUGFIX] Fix RootLevel capability

Benni Mack CR +2 V +2 Normal +42 −18 updated 02/18/25, 14:36

Commit message

The Schema API introduction used the API in a wrong
way, thus, evaluating [ctrl][rootLevel] = 1 and
[ctrl][rootLevel] = 0.

This is now corrected and a test is added.

https://docs.typo3.org/m/typo3/reference-tca/13.4/en-us/Ctrl/#confval-ctrl-rootlevel

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 913

  1. Benni Mack uploaded patch set 1 02/18/25, 10:12

  2. Benni Mack marked it work in progress 02/18/25, 10:15

  3. core-ci voted on patch set 1 V -1 02/18/25, 10:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74302

  4. Benni Mack commented on patch set 2 V -1 02/18/25, 10:33

    Published edit on patch set 1.
  5. core-ci voted on patch set 2 V +1 02/18/25, 10:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74303

  6. Benni Mack uploaded patch set 3 V +1 02/18/25, 12:01

  7. Benni Mack marked it ready for review 02/18/25, 12:01

  8. Benni Mack updated the commit message in patch set 4 02/18/25, 12:04

  9. core-ci voted on patch set 3 V +1 02/18/25, 12:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74308

  10. core-ci voted on patch set 4 V +1 02/18/25, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74309

  11. Christian Kuhn voted on patch set 4 CR +1 V +1 02/18/25, 12:14

  12. Georg Ringer voted on patch set 4 CR +2 V +2 02/18/25, 14:35

  13. Georg Ringer merged patch set 5 02/18/25, 14:36