Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
88260[TASK] Use native browser resizing for viewpage module
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 3
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/60/88260/3 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/60/88260/3 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Issues 1
Files 11
- Build/Sources/Sass/module/_viewpage.scss+4 −27
- Build/Sources/TypeScript/viewpage/main.ts+19 −45
- Build/Gruntfile.js+0 −1
- Build/package-lock.json+13 −25
- Build/package.json+0 −1
- Build/web-test-runner.config.mjs+0 −1
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −5
- typo3/sysext/core/Configuration/JavaScriptModules.php+0 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/interact.jsdeleted+0 −7
- typo3/sysext/viewpage/Resources/Private/Templates/Show.html+0 −4
- typo3/sysext/viewpage/Resources/Public/JavaScript/main.js+1 −1
Review log 69
-
Benjamin Franzke uploaded patch set 1 02/18/25, 12:17
-
Benjamin Franzke uploaded patch set 2 02/18/25, 12:18
-
core-ci voted on patch set 1 V -1 02/18/25, 12:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74311
-
Benjamin Franzke updated the commit message in patch set 3 02/18/25, 12:23
-
core-ci voted on patch set 2 V +1 02/18/25, 12:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74312
-
core-ci voted on patch set 3 V +1 02/18/25, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74313
-
Andreas Kienast commented on patch set 3 02/18/25, 12:33
I'm a bit reluctant here. I fully support the removal of interact, however, the usability of the resize handling became worse, IMO. Previously it was possible to change the size by dragging all edges, not I'm forced to drag a tiny corner. -
Benjamin Franzke commented on patch set 3 02/18/25, 12:36
Reply Unresolved
> usability of the resize handling became worse, IMO I disagree :) It now uses what the user is used to. The browser UI uses the same resize-handles for `<textarea>`. Furthermore I think that a visible resize-drag-element are easier to understand – I could only understand "where" I'm able to resize by reading the code and inspecting the `resize-e` "handles". -
Benjamin Franzke marked it work in progress 02/18/25, 13:53