88261[BUGFIX] Except when 'renderType' is not string in NodeFactory
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Garvin Hicking +2
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1621
-
Garvin Hicking uploaded patch set 1 02/18/25, 12:50
-
Garvin Hicking updated the commit message in patch set 2 02/18/25, 12:52
-
core-ci voted on patch set 1 V +1 02/18/25, 12:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74314
-
core-ci voted on patch set 2 V +1 02/18/25, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74315
-
Oliver Wand voted on patch set 2 CR +1 02/18/25, 14:20
-
Georg Ringer commented on patch set 2 CR +1 V +1 02/18/25, 16:03
I am a big fan of sprintf to avoid all those string concats but I am also fine leaving it like that -
Garvin Hicking commented on patch set 2 02/18/25, 17:06
Reply
I usually get tunnel vision if something similar exists I try to use the style already in place, to keep the diff somewhat readable... maybe as a follow-up? -
Oli Bartsch commented on patch set 2 02/18/25, 17:18
NodeFactory.php:162$type has to be a string. I therefore suggest to explicitly check for this instead of an is_array check. -
Garvin Hicking commented on patch set 3
CR +1V +102/18/25, 18:20Published edit on patch set 2. -
Garvin Hicking commented on patch set 3 02/18/25, 18:21
NodeFactory.php:162ReplyDone, even though now the exception does not fit all scenarios, and I dont want to check for each possible type it could have... so the array situation will be the case of 99,99% of cases and I lect the exception text mostly unchanged. ok? -
core-ci voted on patch set 3 V +1 02/18/25, 18:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74340
-
Oli Bartsch commented on patch set 3 CR +1 V +1 02/18/25, 18:38
NodeFactory.php:162ReplyAcknowledged -
Georg Ringer commented on patch set 4
CR +1V +102/18/25, 19:14Published edit on patch set 3. -
core-ci voted on patch set 4 V +1 02/18/25, 19:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74343
-
Christian Kuhn voted on patch set 4 CR +1 V +1 02/19/25, 17:14
-
Christian Kuhn uploaded patch set 5
CR +1V +102/19/25, 17:16 -
Christian Kuhn voted on patch set 5 CR +1 V +1 02/19/25, 17:16
-
Stefan Bürk voted on patch set 5 CR +1 V +1 02/19/25, 17:16
-
core-ci voted on patch set 5 V +1 02/19/25, 17:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74405
-
Garvin Hicking voted on patch set 5 CR +2 V +2 02/20/25, 08:23
-
Garvin Hicking merged patch set 6 02/20/25, 08:23