Review main Abandoned

88270[FEATURE] PSR-14 event to modify row in database record list

Georg Ringer CR 0 V 0 Normal +193 −10 updated 04/10/26, 18:48

Commit message

Provide a new PSR-14 event which makes it possible
to modify the data and rendering of a row in the database record list.

Due to the changes of #106093 which have also been backported
this, change should be backported to 13.4 as well.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 3

Review log 1317

  1. Georg Ringer uploaded patch set 1 02/18/25, 19:07

  2. Georg Ringer commented on patch set 1 02/18/25, 19:07

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 02/18/25, 19:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74342

  4. Andreas Kienast commented on patch set 1 02/18/25, 20:30

    I don‘t get the reason for the backport to 13.4. Do you consider the related patch a breaking change and are you affected by it?
  5. Georg Ringer commented on patch set 1 02/19/25, 06:57

    Reply Unresolved

    yes I used it in EXT:news
  6. Georg Ringer commented on patch set 2 V -1 02/19/25, 06:58

    Published edit on patch set 1.
  7. core-ci voted on patch set 2 V +1 02/19/25, 07:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74364

  8. Christian Kuhn commented on patch set 2 CR -1 02/19/25, 08:50

    Well, I think we could rather easily revert #106093 at least in v13. I stand my point that adding the css class in BU::workspaceOL() is a hack, so I would like to see it gone in v14, but I don't insist on it (mid-term we need a revamped API for workspace overlay determination). I'm rather reluctant to the event since it binds quite a few internal variables that will be hard to refactor when RecordList receives a bigger overhaul. Isn't there some different solution? Georg, could you elaborate a bit on what exactly you're doing with this in ext:news? I don't really graps your use case. so maybe: * revert v13 of #106093? then look for a better solution in v14 that may include refactoring the surrounding RecordList code in v14 to then have some good event eventually? could be handy for other stuff, too. * full revert of #106093? * streamline the event and maybe refactor this part of RecordList a bit along the way to increase chances of not introducing an event that will become a maintenance problem soon?

    DatabaseRecordList.php:1261

    Hmm. The issue with this event is: It is tied very closely to the current implementation, and will break or easily becomes a maintenance nightmare when recordList is changed. I'm strongly for not handing over $this - this makes everything of public stuff in this class API to the event and renders any changes to the class impossible. For the other arguments: We should see what is *really* needed, and what is in there. We have to anticipate that recordlist will have to see cleanups since we're already haunted by the state it. For now I'll -1 the patch since we should argue about the arguments in detail.
  9. Georg Ringer rebased onto patch set 3 CR -1 V +1 02/19/25, 10:39

  10. core-ci voted on patch set 3 V +1 02/19/25, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74368

  11. Georg Ringer commented on patch set 3 02/19/25, 10:46

    DatabaseRecordList.php:1261 Reply

    I don't see any problems if the recordlist is changed. can you please explain? I also don't see a big need for arguments like $indent but as those are handed to this method, why not add it to the event. If the core changes and doesn't need it anymore, just hand over a default value. If nothing is changed, why not just add those methods and devs can use it, otherwise it will just lead to followups providing the arguments some versions later. If there are big changes happening, then also all other events like ModifyRecordListHeaderColumnsEvent or ModifyRecordListRecordActionsEvent will need to change as well. Which plans are there btw to change the recordlist? is there are specific roadmap? and what points of the roadmap don't fit with this feature. This feature would be a great thing for devs and integrators.
  12. Christian Kuhn commented on patch set 3 CR -1 02/19/25, 10:52

    DatabaseRecordList.php:1261 Reply Unresolved

    especially handing over $this is an issue since you expose the entire $parent with all public stuff to the event, rendering any change to methods or properties a breaking change. this should really be avoided.
  13. Benni Mack wrote 03/27/25, 17:38

    Hashtag added: lolli-feedback
  14. Benni Mack uploaded patch set 4 CR -1 V +1 09/30/25, 16:05

  15. core-ci voted on patch set 4 V +1 09/30/25, 16:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85752

  16. Benni Mack abandoned the change 02/20/26, 21:52

  17. Christian Kuhn wrote 04/10/26, 18:48

    Hashtag removed: lolli-feedback