Review main Abandoned

88271[WIP][TASK] Integrate FormEngine-based rendering for user settings

Benni Mack CR 0 V -1 Expert +1820 −433 updated 03/31/26, 13:54

Commit message

This replaces manual HTML rendering in
SetupModuleController::renderUserSetup() with FormEngine-based
rendering via a custom BackendUserSettingsElement.

The new approach uses a fake TCA table (be_users_settings) and a
custom FormDataGroup to compile user settings through the standard
FormEngine pipeline (FormDataCompiler -> NodeFactory ->
FormResultCompiler).

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Issues 1

Files 12

Review log 812

  1. Benni Mack uploaded patch set 1 02/18/25, 21:23

  2. core-ci voted on patch set 1 V +1 02/18/25, 21:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74346

  3. Benni Mack marked it work in progress 03/21/25, 20:20

  4. Benni Mack uploaded patch set 2 V +1 02/05/26, 18:00

  5. core-ci voted on patch set 2 V -1 02/05/26, 18:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95199

  6. Benni Mack uploaded patch set 3 V -1 02/05/26, 21:03

  7. core-ci voted on patch set 3 V -1 02/05/26, 21:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95214

  8. Benni Mack uploaded patch set 4 V -1 03/02/26, 16:40

  9. core-ci voted on patch set 4 V -1 03/02/26, 16:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97129

  10. Christian Kuhn commented on patch set 4 03/03/26, 14:20

    SetupModuleController.php:170

    We can probably get rid of overriding globals-tca with 'fake tca' (here and in other places) if we manage to get the formEngine patches from Bastien done, especially https://review.typo3.org/c/Packages/TYPO3.CMS/+/92819
  11. Bastien Lutz commented on patch set 4 03/27/26, 13:48

    SetupModuleController.php:170 Reply Unresolved

    I pushed a new patch fixing this. See: https://review.typo3.org/c/Packages/TYPO3.CMS/+/93395
  12. Benni Mack abandoned the change 03/31/26, 13:54

    done