Review main Merged

88273[TASK] Ensure ReferrerEnforcer is stateless

Benni Mack CR +2 V +2 Normal +145 −80 updated 03/22/25, 19:40

Commit message

ReferrerEnforcer does not need to keep its state
as is, so it is changed. This makes it possible
to re-use it with custom requests

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 913

  1. Benni Mack uploaded patch set 1 02/19/25, 09:47

  2. core-ci voted on patch set 1 V -1 02/19/25, 10:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74367

  3. Benni Mack uploaded patch set 2 V -1 03/06/25, 19:21

  4. core-ci voted on patch set 2 V -1 03/06/25, 19:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75239

  5. Benni Mack uploaded patch set 3 V -1 03/06/25, 21:24

  6. core-ci voted on patch set 3 V -1 03/06/25, 21:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75249

  7. Andreas Kienast uploaded patch set 4 V -1 03/07/25, 09:53

  8. core-ci voted on patch set 4 V +1 03/07/25, 09:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75287

  9. Christian Kuhn voted on patch set 4 CR +1 V +1 03/09/25, 08:14

  10. Georg Ringer voted on patch set 4 CR +2 V +2 03/10/25, 06:53

  11. Georg Ringer merged patch set 5 03/10/25, 06:53

  12. Oliver Hader commented on patch set 5 03/12/25, 12:56

    ServiceProvider.php:93

    Is there a reason why this was not define as public service in `Services.yaml` instead?
  13. Benni Mack commented on patch set 5 03/22/25, 19:40

    ServiceProvider.php:93 Reply

    yes. because it is needed in EXT:install / Failsafe mode