Review 13.4 Merged

88275[TASK] Improve LogicException error output for failed image generation

Garvin Hicking CR +2 V +2 Easy +9 −1 updated 02/19/25, 11:20

Commit message

In case image processing fails to resolve width/height to non-0
values, an exception is thrown to ask for a bugreport/feedback.

This exception was missing vital information to investigate an issue.

With this patch, the extra information about incoming width/height,
resolved width/height and the array of options and croparea
configuration is revealed.

The output is like:

```
Image processing instructions did not resolve into coherent positive
width and height values. This is a bug. Please report. Extra details:
incomingWidth: 2044, incomingHeight: 852, width: 1000, height: 417,
options: { "width": null, "height": null, "maxWidth": 1000,
"maxHeight": 1000, "crop": null }, cropArea: { "x": 0, "y": 0,
"width": 2044, "height": 852 }
```

(Screenshot in issue; exception messages cannot be formatted.)

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oliver Wand +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 45

  1. Garvin Hicking commented on patch set 1 02/19/25, 11:08

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 02/19/25, 11:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74373

  3. Oliver Wand voted on patch set 1 CR +1 02/19/25, 11:18

  4. Garvin Hicking voted on patch set 1 CR +2 V +2 02/19/25, 11:20

  5. Garvin Hicking merged patch set 2 02/19/25, 11:20