Review main Merged

88278[TASK] Turn some extbase unit tests into functionals

Christian Kuhn CR +2 V +2 Hard +182 −514 updated 02/19/25, 16:59

Commit message

As a preparation for #106202, we turn yet another set
of heavily mocking unit tests into functional tests
to clean up various `@todo` comments and clean up
class `Backend`.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 11

Review log 1116

  1. Christian Kuhn uploaded patch set 1 02/19/25, 13:46

  2. core-ci voted on patch set 1 V +1 02/19/25, 13:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74390

  3. Christian Kuhn uploaded patch set 2 V +1 02/19/25, 14:43

  4. core-ci voted on patch set 2 V +1 02/19/25, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74393

  5. Christian Kuhn uploaded patch set 3 V +1 02/19/25, 16:05

  6. core-ci voted on patch set 3 V +1 02/19/25, 16:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74399

  7. Christian Kuhn uploaded patch set 4 V +1 02/19/25, 16:13

  8. Benni Mack commented on patch set 4 02/19/25, 16:17

    Backend.php:70

    can we get rid of the todo?
  9. Christian Kuhn commented on patch set 4 02/19/25, 16:18

    Backend.php:70 Reply

    ah missed that. yes.
  10. Christian Kuhn uploaded patch set 5 02/19/25, 16:18

  11. core-ci voted on patch set 4 V +1 02/19/25, 16:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74400

  12. core-ci voted on patch set 5 V +1 02/19/25, 16:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74401

  13. Benni Mack voted on patch set 5 CR +1 V +1 02/19/25, 16:32

  14. Stefan Bürk voted on patch set 5 CR +1 V +1 02/19/25, 16:58

  15. Christian Kuhn voted on patch set 5 CR +2 V +2 02/19/25, 16:58

  16. Christian Kuhn merged patch set 6 02/19/25, 16:59