Review main Merged

88279[BUGFIX] Check the shortcut target page UID to identify its ACT and CUR state

Oliver Eglseder CR +2 V +2 Easy +6 −6 updated 03/25/25, 12:55

Commit message

Introduced in #99838, the uid in _SHORTCUT_ORIGINAL_PAGE_UID was changed to the logically correct value, but it broke the behavior for menu itemStates.
This fix checks if a shortcut target was resolved (which is the case when _SHORTCUT_ORIGINAL_PAGE_UID is set) and the uses the uid of the resolved page instead of the uid of the shortcut page again.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 913

  1. Oliver Eglseder uploaded patch set 1 02/19/25, 14:00

  2. core-ci voted on patch set 1 V +1 02/19/25, 14:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74391

  3. Benni Mack updated the commit message in patch set 2 V +1 02/19/25, 16:23

  4. core-ci voted on patch set 2 V +1 02/19/25, 16:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74402

  5. Benni Mack voted on patch set 2 CR +1 V +1 03/06/25, 21:00

  6. Benni Mack updated the commit message in patch set 3 CR +1 V +1 03/24/25, 20:14

  7. Benni Mack voted on patch set 3 CR +1 V +1 03/24/25, 20:21

  8. core-ci voted on patch set 3 V +1 03/24/25, 20:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76173

  9. Benni Mack updated the commit message in patch set 4 CR +1 V +1 03/25/25, 12:43

  10. core-ci voted on patch set 4 V +1 03/25/25, 12:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76247

  11. Benni Mack voted on patch set 4 CR +1 V +1 03/25/25, 12:53

  12. Georg Ringer voted on patch set 4 CR +2 V +2 03/25/25, 12:55

  13. Georg Ringer merged patch set 5 03/25/25, 12:55