Review main Merged

88281[BUGFIX] Prevent missing upscaled thumbnails

Garvin Hicking CR +2 V +2 Normal +80 −8 updated 03/03/25, 12:24

Commit message

In case `TYPO3_CONF_VARS['GFX']['processor_allowUpscaling'] = false`
is set, and an image smaller than 150px is uploaded,
no thumbnail will be shown in the FormEngine sys_file_metadata
editing interface (FileInfoElement). No processed file
will be created.

On top of that, in certain scenarios (see issue) this can
actually lead to uploaded original images getting wrongfully moved
to the processing directory and disappear from the file list.

This patch ensures that thumbnail processing based on the
original image is passed on when either width OR height
is below the target dimensions. Previously, this only
happened if both dimensions were below 150x150.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 3

Files 3

Review log 68

  1. Garvin Hicking uploaded patch set 1 02/19/25, 15:07

  2. core-ci voted on patch set 1 V +1 02/19/25, 15:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74394

  3. Garvin Hicking uploaded patch set 2 V +1 02/19/25, 15:37

  4. core-ci voted on patch set 2 V +1 02/19/25, 15:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74397

  5. Georg Ringer voted on patch set 2 CR +1 V +1 03/02/25, 15:04

  6. Christian Kuhn voted on patch set 2 CR +1 V +1 03/03/25, 12:03

  7. Garvin Hicking voted on patch set 2 CR +2 V +2 03/03/25, 12:08

  8. Garvin Hicking merged patch set 3 03/03/25, 12:24