Review 12.4 Abandoned

88285[TASK] Add index to sys_refindex for EXT:form softref_key lookup

Garvin Hicking CR 0 V 0 Easy +9 −0 updated 02/20/25, 11:22

Commit message

This patch adds another sys_refindex key for EXT:form specific
database queries like:

```
SELECT ref_uid
  FROM sys_refindex
 WHERE softref_key='formPersistenceIdentifier'
   AND ref_uid > 0;
```

which would otherwise create a full-table scan and perform bad.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 68

  1. Garvin Hicking commented on patch set 1 02/19/25, 20:41

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/form/ext_tables.sql
  2. Garvin Hicking commented on patch set 2 02/19/25, 20:42

    Published edit on patch set 1.
  3. Garvin Hicking commented on patch set 2 CR -1 02/19/25, 20:42

    This change is ready for review.
    Needs v12 verification first
  4. core-ci voted on patch set 2 V +1 02/19/25, 20:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74416

  5. core-ci voted on patch set 1 V -1 02/19/25, 20:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74415

  6. Christian Kuhn voted on patch set 2 CR -2 02/20/25, 11:01

  7. Christian Kuhn voted on patch set 2 CR 0 02/20/25, 11:08

  8. Garvin Hicking abandoned the change 02/20/25, 11:22

    Not doing this