Review main Merged

88286[BUGFIX] Premature end of script headers due to X-TYPO3-Cache-Tags

Sascha Nowak CR +2 V +2 Normal +113 −1 updated 04/09/25, 23:27

Commit message

Cache Tag header exceeding the maximum length of 8000 characters
will be automatically split into multiple header lines. For example
X-TYPO3-Cache-Tags, X-TYPO3-Cache-Tags-1, X-TYPO3-Cache-Tags-2
could be in the response if the number of cache tags is very high
and frontend is in debug mode.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 2330

Show 35 earlier messages
  1. Sascha Nowak uploaded patch set 1 02/19/25, 21:25

  2. core-ci voted on patch set 1 V -1 02/19/25, 21:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74417

  3. Sascha Nowak uploaded patch set 2 V -1 02/19/25, 21:35

  4. Sascha Nowak uploaded patch set 3 02/19/25, 21:43

  5. core-ci voted on patch set 2 V -1 02/19/25, 21:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74419

  1. core-ci voted on patch set 3 V +1 02/19/25, 21:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74420

  2. Mathias Brodala commented on patch set 3 CR -1 02/20/25, 07:52

    CacheDataCollectorAttribute.php:57

    This must be used with a named constant and more background provided where it came from.
  3. Josef Glatz commented on patch set 3 02/25/25, 13:15

    CacheDataCollectorAttribute.php:57 Reply

    > This must be used with a named constant and more background provided where it came from. plus: rSt/important as this changes the response header behaviour. Do we have to also consider the different allowed maximum header value limits based on the used web server or can we use the overall minimal length of yet known web servers? I would also like to point out that a reverse proxy can be used in front of a web server and is being used more and more often, so such limits must also be taken into account. The aim must be that no patches have to be applied to the individual TYPO3 project in order to run it in more advanced hosting scenarios.
  4. Sascha Nowak rebased onto patch set 4 CR -1 V +1 03/26/25, 06:07

  5. core-ci voted on patch set 4 V +1 03/26/25, 06:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76339

  6. Sascha Nowak uploaded patch set 5 V +1 03/26/25, 06:42

  7. Andreas Kienast commented on patch set 5 CR -1 03/26/25, 06:49

    Important-105703-PrematureEndOfScriptHeadersDueToXTYPO3CacheTags.rst:1

    FYI: Retrospectively added rst files go into 13.4.x, if the patch gets backported. Will take care of this.
  8. Andreas Kienast uploaded patch set 6 CR -1 03/26/25, 06:50

  9. Andreas Kienast commented on patch set 6 03/26/25, 06:50

    Important-105703-PrematureEndOfScriptHeadersDueToXTYPO3CacheTags.rst:1 Reply

    Done
  10. core-ci voted on patch set 5 V +1 03/26/25, 06:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76341

  11. Andreas Kienast commented on patch set 6 03/26/25, 06:52

    CacheDataCollectorAttribute.php:65

    I wonder whether this is something we should implement more lowlevel, in `TYPO3\CMS\Core\Http\Message->withHeader()`…
  12. Sascha Nowak uploaded patch set 7 03/26/25, 06:55

  13. Sascha Nowak commented on patch set 7 03/26/25, 06:57

    Important-105703-PrematureEndOfScriptHeadersDueToXTYPO3CacheTags.rst:1 Reply

    Thanks for the feedback, I moved it to the correct folder.
  14. core-ci voted on patch set 6 V +1 03/26/25, 06:58 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 7 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76342

  15. Sascha Nowak commented on patch set 7 03/26/25, 06:59

    CacheDataCollectorAttribute.php:65 Reply

    I was thinking about this too, but I can't foresee the effects
  16. core-ci voted on patch set 7 V +1 03/26/25, 07:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76345

  17. Benjamin Franzke commented on patch set 7 03/27/25, 07:36

    CacheDataCollectorAttribute.php:65 Reply

    I'd say: No Reason: `Message->withHeader` is PSR-7 and PSR-7 is here to implement HTTP and not webserver specific limitation. It's fine to keep this outside (we actually want to be PSR-7 implementation agnostic whenever possible.
  18. Christian Kuhn voted on patch set 7 CR +1 V +1 04/08/25, 18:26

  19. Benni Mack commented on patch set 7 CR -1 04/08/25, 18:37

    testing
  20. Benni Mack voted on patch set 7 CR +2 V +2 04/08/25, 18:42

  21. Benni Mack merged patch set 8 04/08/25, 18:42

  22. Simon Schaufelberger commented on patch set 8 04/08/25, 19:15

    Important-105703-PrematureEndOfScriptHeadersDueToXTYPO3CacheTags.rst:7

    These lines don't go until the end but I think this is necessary for correct rendering of the docs, or?
  23. Andreas Kienast commented on patch set 8 04/09/25, 06:53

    Important-105703-PrematureEndOfScriptHeadersDueToXTYPO3CacheTags.rst:7 Reply

  24. Simon Schaufelberger commented on patch set 8 04/09/25, 23:27

    Important-105703-PrematureEndOfScriptHeadersDueToXTYPO3CacheTags.rst:7 Reply

    Acknowledged