88286[BUGFIX] Premature end of script headers due to X-TYPO3-Cache-Tags
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 3
Review log 2330
Show 35 earlier messages
-
Sascha Nowak uploaded patch set 1 02/19/25, 21:25
-
core-ci voted on patch set 1 V -1 02/19/25, 21:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74417
-
Sascha Nowak uploaded patch set 2
V -102/19/25, 21:35 -
Sascha Nowak uploaded patch set 3 02/19/25, 21:43
-
core-ci voted on patch set 2 V -1 02/19/25, 21:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74419
-
core-ci voted on patch set 3 V +1 02/19/25, 21:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74420
-
Mathias Brodala commented on patch set 3 CR -1 02/20/25, 07:52
-
Josef Glatz commented on patch set 3 02/25/25, 13:15
CacheDataCollectorAttribute.php:57Reply> This must be used with a named constant and more background provided where it came from. plus: rSt/important as this changes the response header behaviour. Do we have to also consider the different allowed maximum header value limits based on the used web server or can we use the overall minimal length of yet known web servers? I would also like to point out that a reverse proxy can be used in front of a web server and is being used more and more often, so such limits must also be taken into account. The aim must be that no patches have to be applied to the individual TYPO3 project in order to run it in more advanced hosting scenarios. -
Sascha Nowak rebased onto patch set 4
CR -1V +103/26/25, 06:07 -
core-ci voted on patch set 4 V +1 03/26/25, 06:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76339
-
Sascha Nowak uploaded patch set 5
V +103/26/25, 06:42 -
Andreas Kienast commented on patch set 5 CR -1 03/26/25, 06:49
Important-105703-PrematureEndOfScriptHeadersDueToXTYPO3CacheTags.rst:1FYI: Retrospectively added rst files go into 13.4.x, if the patch gets backported. Will take care of this. -
Andreas Kienast uploaded patch set 6
CR -103/26/25, 06:50 -
Andreas Kienast commented on patch set 6 03/26/25, 06:50
Important-105703-PrematureEndOfScriptHeadersDueToXTYPO3CacheTags.rst:1ReplyDone -
core-ci voted on patch set 5 V +1 03/26/25, 06:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76341
-
Sascha Nowak commented on patch set 5 03/26/25, 06:51
CacheDataCollectorAttribute.php:57ReplyAs many developers use ddev, I checked there configuration. They use 16k as default: https://github.com/ddev/ddev/blob/main/containers/ddev-nginx-proxy-router/etc/nginx/nginx.conf#L30 https://github.com/ddev/ddev/blob/main/containers/ddev-webserver/ddev-webserver-base-files/etc/nginx/nginx.conf#L134 Apache2 has a default of 8kb: https://httpd.apache.org/docs/2.2/mod/core.html#limitrequestfieldsize nginx has the same default of 8kb: https://nginx.org/en/docs/http/ngx_http_core_module.html#large_client_header_buffers traefik has a default of 1MB: https://github.com/golang/go/blob/d36353499f673c89a267a489beb80133a14a75f9/src/net/http/server.go#L913-L916 Caddy has a default of 1MB: https://caddyserver.com/docs/caddyfile/options#max-header-size I think we are good to go with 8000 characters. -
Andreas Kienast commented on patch set 6 03/26/25, 06:52
CacheDataCollectorAttribute.php:65I wonder whether this is something we should implement more lowlevel, in `TYPO3\CMS\Core\Http\Message->withHeader()`… -
Sascha Nowak uploaded patch set 7 03/26/25, 06:55
-
Sascha Nowak commented on patch set 7 03/26/25, 06:57
Important-105703-PrematureEndOfScriptHeadersDueToXTYPO3CacheTags.rst:1ReplyThanks for the feedback, I moved it to the correct folder. -
core-ci voted on patch set 6 V +1 03/26/25, 06:58 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 7 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76342
-
Sascha Nowak commented on patch set 7 03/26/25, 06:59
CacheDataCollectorAttribute.php:65ReplyI was thinking about this too, but I can't foresee the effects -
core-ci voted on patch set 7 V +1 03/26/25, 07:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76345
-
Benjamin Franzke commented on patch set 7 03/27/25, 07:36
CacheDataCollectorAttribute.php:65ReplyI'd say: No Reason: `Message->withHeader` is PSR-7 and PSR-7 is here to implement HTTP and not webserver specific limitation. It's fine to keep this outside (we actually want to be PSR-7 implementation agnostic whenever possible. -
Christian Kuhn voted on patch set 7 CR +1 V +1 04/08/25, 18:26
-
Benni Mack commented on patch set 7 CR -1 04/08/25, 18:37
testing -
Benni Mack voted on patch set 7 CR +2 V +2 04/08/25, 18:42
-
Benni Mack merged patch set 8 04/08/25, 18:42
-
Simon Schaufelberger commented on patch set 8 04/08/25, 19:15
Important-105703-PrematureEndOfScriptHeadersDueToXTYPO3CacheTags.rst:7These lines don't go until the end but I think this is necessary for correct rendering of the docs, or? -
Andreas Kienast commented on patch set 8 04/09/25, 06:53
Important-105703-PrematureEndOfScriptHeadersDueToXTYPO3CacheTags.rst:7ReplyApparently that's not the case anymore: https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.4.x/Important-105703-PrematureEndOfScriptHeadersDueToXTYPO3CacheTags.html -
Simon Schaufelberger commented on patch set 8 04/09/25, 23:27
Important-105703-PrematureEndOfScriptHeadersDueToXTYPO3CacheTags.rst:7ReplyAcknowledged
CacheDataCollectorAttribute.php:57