Review main Merged

88294[TASK] Bind FormEngine main events natively

Andreas Kienast CR +2 V +2 Normal +39 −29 updated 02/20/25, 10:34

Commit message

The events in the FormEngine main module are still bound via jQuery. It
is finally time to resolve this and use our own Events API, based on
native event handling.

Bonus: There was one event bound to the element
`.t3js-editform-submitButton` which doesn't exist anymore since TYPO3
v9, whose event handler is now finally removed as well.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Georg Ringer +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Georg Ringer +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Andreas Kienast uploaded patch set 1 02/20/25, 07:40

  2. core-ci voted on patch set 1 V +1 02/20/25, 07:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74443

  3. Benjamin Franzke voted on patch set 1 CR +1 02/20/25, 08:00

  4. Benjamin Franzke voted on patch set 1 V +1 02/20/25, 08:03

  5. Georg Ringer voted on patch set 1 CR +1 V +1 02/20/25, 08:17

  6. Garvin Hicking commented on patch set 1 CR +1 V +1 02/20/25, 08:18

    Tested on Chromium and FF macOS
  7. Andreas Kienast voted on patch set 1 CR +2 V +2 02/20/25, 09:57

  8. Andreas Kienast merged patch set 2 02/20/25, 10:34