Review main Merged

88296[BUGFIX] Prevent database lookups for unsaved records in FormEngine

Oli Bartsch CR +2 V +2 Easy +3 −3 updated 02/20/25, 15:09

Commit message

EditDocumentController has been improved
to check whether it is handling an unsaved
record before performing any database lookups.

This therefore also prevents an undefined
array key access.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1012

  1. Oli Bartsch uploaded patch set 1 02/20/25, 08:16

  2. Benjamin Franzke commented on patch set 1 02/20/25, 08:26

    Patch looks good, but how is this case produced? When a file has to sys_file_metadata record, editing interface is not loadable at all: > Record with uid 3050 from table sys_file_metadata not found
  3. core-ci voted on patch set 1 V +1 02/20/25, 08:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74447

  4. Oli Bartsch commented on patch set 1 02/20/25, 08:30

    Reply

    This is extracted from https://review.typo3.org/c/Packages/TYPO3.CMS/+/88282. So when you just create a new sys_file_metadata via FormEngine. /record/edit?&edit[sys_file_metadata][0]=new&defVals[sys_file_metadata][file]=123;
  5. Oli Bartsch rebased onto patch set 2 V +1 02/20/25, 08:41

  6. core-ci voted on patch set 2 V +1 02/20/25, 08:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74449

  7. Oli Bartsch commented on patch set 2 02/20/25, 09:09

    Reply

    Done
  8. Benjamin Franzke commented on patch set 2 CR +1 V +1 02/20/25, 10:36

    Reply

    thx
  9. Benni Mack voted on patch set 2 CR +1 V +1 02/20/25, 11:33

  10. Christian Kuhn voted on patch set 2 CR +1 02/20/25, 12:09

  11. Oli Bartsch voted on patch set 2 CR +2 V +2 02/20/25, 15:09

  12. Oli Bartsch merged patch set 3 02/20/25, 15:09