Review main Merged

88298[TASK] Remove jQuery from FormEngine.toggleCheckboxField()

Andreas Kienast CR +2 V +2 Easy +14 −11 updated 02/21/25, 11:44

Commit message

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1011

  1. Andreas Kienast uploaded patch set 1 02/20/25, 11:31

  2. core-ci voted on patch set 1 V +1 02/20/25, 11:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74461

  3. Garvin Hicking commented on patch set 1 CR +1 V +1 02/20/25, 11:52

    Tested with a few nullable styleguide types (color, input, select) in Chromium+FF
  4. Christian Kuhn voted on patch set 1 V +1 02/20/25, 12:12

  5. Oliver Hader voted on patch set 1 CR +1 02/21/25, 08:51

  6. Oliver Hader commented on patch set 1 02/21/25, 09:03

    form-engine.ts:709

    I guess there should be a check, in case `checkbox` is null (not found in DOM).
  7. Oliver Hader voted on patch set 1 V +1 02/21/25, 09:08

  8. Andreas Kienast commented on patch set 1 02/21/25, 09:11

    form-engine.ts:709 Reply

    This can only be the case with `FormEngine.initializeNullWithPlaceholderCheckboxes()`, implying broken markup. Would throwing an explicit `Error` here fine with you?
  9. Oliver Hader commented on patch set 1 02/21/25, 09:30

    form-engine.ts:709 Reply

    Acknowledged
  10. Andreas Kienast voted on patch set 1 CR +2 V +2 02/21/25, 11:04

  11. Andreas Kienast merged patch set 2 02/21/25, 11:44