88298[TASK] Remove jQuery from FormEngine.toggleCheckboxField()
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Garvin Hicking +1
- Oliver Hader +1
-
Verified V +2 Done
- Andreas Kienast +2
- Garvin Hicking +1
- Christian Kuhn +1
- Oliver Hader +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1011
-
Andreas Kienast uploaded patch set 1 02/20/25, 11:31
-
core-ci voted on patch set 1 V +1 02/20/25, 11:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74461
-
Garvin Hicking commented on patch set 1 CR +1 V +1 02/20/25, 11:52
Tested with a few nullable styleguide types (color, input, select) in Chromium+FF -
Christian Kuhn voted on patch set 1 V +1 02/20/25, 12:12
-
Oliver Hader voted on patch set 1 CR +1 02/21/25, 08:51
-
Oliver Hader commented on patch set 1 02/21/25, 09:03
form-engine.ts:709I guess there should be a check, in case `checkbox` is null (not found in DOM). -
Oliver Hader voted on patch set 1 V +1 02/21/25, 09:08
-
Andreas Kienast commented on patch set 1 02/21/25, 09:11
form-engine.ts:709ReplyThis can only be the case with `FormEngine.initializeNullWithPlaceholderCheckboxes()`, implying broken markup. Would throwing an explicit `Error` here fine with you? -
Oliver Hader commented on patch set 1 02/21/25, 09:30
form-engine.ts:709ReplyAcknowledged -
Andreas Kienast voted on patch set 1 CR +2 V +2 02/21/25, 11:04
-
Andreas Kienast merged patch set 2 02/21/25, 11:44